Bump Node to 24 and update CI/docs tooling#827
Draft
jonobr1 wants to merge 2 commits into
Draft
Conversation
Update CI and local tooling to Node v24.14.1: workflows (setup-node) and .nvmrc now target Node 24, workflows use npm ci and enable caching, and the lint job is renamed to Validate with an added TypeScript check. Adjusted .npmrc to use legacy-peer-deps, updated README instructions to require Node 24.14.1, added VuePress v2 files and SCSS styles under wiki/.vuepress, and ignore the wiki .vuepress temp/cache in .gitignore.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the docs/tooling stack for Node 24 and migrates the VuePress wiki setup toward VuePress 2, including updated CI install steps and documentation guidance.
Changes:
- Updates Node/npm workflow usage,
.nvmrc,.npmrc, and README guidance for Node24.14.1. - Migrates VuePress configuration from v1 JavaScript/Stylus files to v2 TypeScript/SCSS files.
- Updates wiki components, redirects, styles, docs generation, and selected generated docs metadata.
Reviewed changes
Copilot reviewed 27 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/codeql.yml |
Updates CodeQL Node version. |
.github/workflows/copilot-setup-steps.yml |
Switches dependency install to npm ci. |
.github/workflows/lint.yml |
Renames validation workflow, uses Node 24/npm ci, adds TypeScript check. |
.github/workflows/publish.yml |
Updates publish Node version. |
.gitignore |
Ignores VuePress cache/temp folders. |
.npmrc |
Enables legacy peer dependency resolution. |
.nvmrc |
Updates local Node version. |
README.md |
Updates docs tooling Node instructions. |
package.json |
Updates VuePress/docs dependencies and overrides. |
utils/document.js |
Updates docs generation to async jsdoc-api usage. |
wiki/.vuepress/client.js |
Registers VuePress 2 client components. |
wiki/.vuepress/components/carbon-ads.vue |
Migrates Carbon Ads component to Vue 3 style. |
wiki/.vuepress/components/custom-button.vue |
Migrates custom button and file-size lookup. |
wiki/.vuepress/components/example-card.vue |
Migrates example card component and slug handling. |
wiki/.vuepress/components/inline-editor.vue |
Migrates inline editor component lifecycle/slot handling. |
wiki/.vuepress/components/redirect-page.vue |
Removes old redirect component. |
wiki/.vuepress/components/version-link.vue |
Migrates version link component. |
wiki/.vuepress/config.js |
Removes old VuePress 1 config. |
wiki/.vuepress/config.ts |
Adds VuePress 2 config, redirects, sidebar/search helpers. |
wiki/.vuepress/enhanceApp.js |
Removes old VuePress 1 app enhancement. |
wiki/.vuepress/styles/index.scss |
Reworks VuePress site styling in SCSS. |
wiki/.vuepress/styles/palette.scss |
Adds VuePress 2 SCSS palette variables. |
wiki/.vuepress/styles/palette.styl |
Removes old Stylus palette. |
wiki/.vuepress/theme/index.js |
Removes old custom theme wrapper. |
wiki/README.md |
Updates download buttons for new size lookup. |
wiki/change-log/README.md |
Removes old redirect page. |
wiki/docs/README.md |
Removes old redirect page. |
wiki/docs/renderers/webgl/README.md |
Updates generated WebGL source line links. |
wiki/donate/README.md |
Removes old redirect page. |
Comments suppressed due to low confidence (1)
.github/workflows/lint.yml:23
- Running
tscfrom the repository root does not install the nestedtests/typescriptpackage, whosepackage.jsondeclarestwo.jsasfile:../../and its own TypeScript dependency. After the rootnpm ci, this command has notests/typescript/node_modules/two.jssymlink to resolve theimport Two from 'two.js'sample, so the validation job can fail with a missing module instead of exercising the sample package. Install/run the check fromtests/typescript(or add an explicit root-level module resolution path) before invokingtsc.
shell: bash
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| border: none; | ||
| font-weight: normal; | ||
| } | ||
| <style scoped> |
Comment on lines
+304
to
+307
| const header = { | ||
| text, | ||
| link: `#${slugify(text)}`, | ||
| children: [], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CI and local tooling to Node v24.14.1: workflows (setup-node) and .nvmrc now target Node 24, workflows use npm ci and enable caching, and the lint job is renamed to Validate with an added TypeScript check. Adjusted .npmrc to use legacy-peer-deps, updated README instructions to require Node 24.14.1, added VuePress v2 files and SCSS styles under wiki/.vuepress, and ignore the wiki .vuepress temp/cache in .gitignore.