Test if BigInt instance is a finite number#34
Open
omrilotan wants to merge 5 commits into
Open
Conversation
Rudxain
reviewed
Oct 4, 2024
| return finite(+num); | ||
| } | ||
| if (typeof num === 'bigint') { | ||
| return finite(Number(num)) |
Author
There was a problem hiding this comment.
the "finite" function (Number.isFinite) will check whether the output is a value that can be represented by a Javascript number. The return value will be a Boolean.
There was a problem hiding this comment.
I'm sorry, I wasn't clear. I meant that BigInts could always be considered as "valid numerical values" (as in math), not necessarily "all BigInts are valid Numbers, because they never coerce to NaN"
There was a problem hiding this comment.
Wait, now that I think about it, that should be a separate function named isNumeric
Author
There was a problem hiding this comment.
Yeah, probably.
Anyway I don't think this changeset is getting merged (almost three years old 🍰)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigInt can represent a value that can be represented by a number or larger.
This now checks if it is representing a value that can be represented by a Javascript number.
Disclosure: There's a performance hit for non-string or numbers. Others are obviously not affected
