Skip to content

Commit bff04dd

Browse files
authored
Merge pull request #3957 from jooby-project/3953
hibernate: package scanning doesn't work + 7.3.4
2 parents 41b8aeb + 7df998e commit bff04dd

6 files changed

Lines changed: 28 additions & 2 deletions

File tree

jooby/src/main/java/io/jooby/Server.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,17 @@ abstract class Base implements Server {
9393

9494
private final AtomicBoolean stopping = new AtomicBoolean();
9595

96+
/**
97+
* Clears custom connection lost listeners. Intended for internal testing use to prevent static
98+
* state leakage between tests. Internal usage only.
99+
*/
100+
static void clearState() {
101+
connectionLostListeners.clear();
102+
connectionLostListeners.add(Base.CONNECTION_LOST);
103+
addressInUseListeners.clear();
104+
addressInUseListeners.add(Base.ADDRESS_IN_USE);
105+
}
106+
96107
protected void fireStart(List<Jooby> applications, Executor defaultWorker) {
97108
for (Jooby app : applications) {
98109
app.setDefaultWorker(defaultWorker).start(this);

jooby/src/test/java/io/jooby/DefaultContextTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -865,7 +865,7 @@ void sendErrorCustomHandlerException() {
865865
doThrow(new RuntimeException("Handler crashed")).when(errorHandler).apply(any(), any(), any());
866866

867867
ctx.sendError(cause);
868-
verify(log).error(anyString(), anyString(), any(RuntimeException.class));
868+
verify(log).error(anyString(), any(RuntimeException.class));
869869
}
870870

871871
@Test

jooby/src/test/java/io/jooby/Issue2369.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,18 @@
88
import static org.junit.jupiter.api.Assertions.assertFalse;
99
import static org.junit.jupiter.api.Assertions.assertTrue;
1010

11+
import org.junit.jupiter.api.AfterEach;
12+
import org.junit.jupiter.api.BeforeEach;
1113
import org.junit.jupiter.api.Test;
1214

1315
public class Issue2369 {
1416

17+
@BeforeEach
18+
@AfterEach
19+
public void cleanState() {
20+
Server.Base.clearState();
21+
}
22+
1523
@Test
1624
public void shouldCustomizeServerLostException() {
1725
Throwable cause = new IllegalArgumentException();

modules/jooby-hibernate/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,12 @@
2424
<artifactId>hibernate-core</artifactId>
2525
</dependency>
2626

27+
<dependency>
28+
<groupId>org.hibernate.orm</groupId>
29+
<artifactId>hibernate-scan-jandex</artifactId>
30+
<version>${hibernate.version}</version>
31+
</dependency>
32+
2733
<!-- Test dependencies -->
2834
<dependency>
2935
<groupId>org.junit.jupiter</groupId>

modules/jooby-hibernate/src/main/java/module-info.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,5 @@
1616
requires jakarta.inject;
1717
requires jakarta.persistence;
1818
requires java.naming;
19+
requires org.hibernate.orm.scan.jandex;
1920
}

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
<!-- data -->
7474
<HikariCP.version>7.0.2</HikariCP.version>
7575
<log4jdbc.version>1.2</log4jdbc.version>
76-
<hibernate.version>7.0.4.Final</hibernate.version>
76+
<hibernate.version>7.3.4.Final</hibernate.version>
7777
<ebean.version>17.6.0</ebean.version>
7878
<jdbi.version>3.53.0</jdbi.version>
7979
<flyway.version>11.20.1</flyway.version>

0 commit comments

Comments
 (0)