Remove FlashScope, just allow to modify the cookie name

Author: jknack

jooby/src/main/java/io/jooby/Context.java

@@ -121,7 +121,8 @@ public interface Context extends Registry {
 
   default @Nonnull FlashMap flashMap() {
     return (FlashMap) getAttributes()
-        .computeIfAbsent(FlashMap.NAME, key -> FlashMap.create(this, FlashScope.cookie()));
+        .computeIfAbsent(FlashMap.NAME, key -> FlashMap
+            .create(this, new Cookie(getRouter().getFlashCookie()).setHttpOnly(true)));
   }
 
   default @Nonnull Value flash(@Nonnull String name) {

jooby/src/main/java/io/jooby/FlashScope.java

@@ -505,6 +505,15 @@ public Jooby errorCode(@Nonnull Class<? extends Throwable> type,
     return this;
   }
 
+  @Nonnull @Override public String getFlashCookie() {
+    return router.getFlashCookie();
+  }
+
+  @Nonnull @Override public Jooby setFlashCookie(@Nonnull String name) {
+    router.setFlashCookie(name);
+    return this;
+  }
+
   /**
    * Start application, find a web server, deploy application, start router, extension modules,
    * etc..

jooby/src/main/java/io/jooby/Jooby.java

@@ -640,6 +640,21 @@ default Router error(@Nonnull Predicate<StatusCode> predicate,
 
   @Nonnull Router executor(@Nonnull String name, @Nonnull Executor executor);
 
+  /**
+   * Name of the flash cookie. Defaults is: <code>jooby.flash</code>.
+   *
+   * @return Name of the flash cookie. Defaults is: <code>jooby.flash</code>.
+   */
+  @Nonnull String getFlashCookie();
+
+  /**
+   * Set flash cookie name.
+   *
+   * @param name Flash cookie name.
+   * @return This router.
+   */
+  @Nonnull Router setFlashCookie(@Nonnull String name);
+
   /**
    * Normalize a path by removing consecutives <code>/</code>(slashes), make it lower case and
    * removing trailing slash.

jooby/src/main/java/io/jooby/Router.java

@@ -154,6 +154,8 @@ public Stack executor(Executor executor) {
 
   private SessionOptions sessionOptions = new SessionOptions();
 
+  private String flashName = "jooby.flash";
+
   public RouterImpl(ClassLoader loader) {
     this.source = new ClassSource(loader);
     this.analyzer = new RouteAnalyzer(source, false);
@@ -523,6 +525,15 @@ public void destroy() {
     return services.require(type);
   }
 
+  @Nonnull @Override public String getFlashCookie() {
+    return flashName;
+  }
+
+  @Nonnull @Override public Router setFlashCookie(@Nonnull String name) {
+    this.flashName = name;
+    return this;
+  }
+
   @Override public String toString() {
     StringBuilder buff = new StringBuilder();
     int size = IntStream.range(0, routes.size())

jooby/src/main/java/io/jooby/internal/RouterImpl.java

@@ -2118,8 +2118,7 @@ public void flashScope() {
   public void customFlashScope() {
     new JoobyRunner(app -> {
       app.setContextPath("/custom");
-
-      app.install(new FlashScope(new Cookie("f")));
+      app.setFlashCookie("f");
 
       app.get("/flash", ctx -> {
         ctx.flash("success", "Thank you!");
@@ -2129,7 +2128,7 @@ public void customFlashScope() {
       client.get("/custom/flash", rsp -> {
         assertEquals(200, rsp.code());
         String setCookie = rsp.header("Set-Cookie");
-        assertEquals("f=success=Thank+you%21;Path=/custom", setCookie);
+        assertEquals("f=success=Thank+you%21;Path=/custom;HttpOnly", setCookie);
       });
     });
   }