fix reboot on webui wifi connect taking too long

Author: joojoooo

src/board_driver.cpp

@@ -1001,7 +1001,7 @@ void BoardDriver::loadLedSettings() {
     return;
   }
   Preferences prefs;
-  prefs.begin("ledSettings", true);
+  prefs.begin("ledSettings", false);
   brightness = prefs.getUChar("brightness", BRIGHTNESS);
   dimMultiplier = prefs.getUChar("dimMult", 70);
   prefs.end();
@@ -1040,10 +1040,10 @@ void BoardDriver::loadHardwareConfig() {
   if (!ChessUtils::ensureNvsInitialized()) return;
 
   Preferences prefs;
-  prefs.begin("hwConfig", true);
+  prefs.begin("hwConfig", false);
   if (!prefs.isKey("ver")) {
     prefs.end();
-    Serial.println("No saved hardware config — using compile-time defaults");
+    Serial.println("No saved hardware config, using compile-time defaults");
     return;
   }
   hwConfig.ledPin = prefs.getUChar("ledPin", LED_PIN);

src/main.cpp

@@ -105,6 +105,9 @@ void setup() {
 }
 
 void loop() {
+  // Process deferred WiFi reconnection (from web UI)
+  wifiManager.checkPendingWiFi();
+
   // Check for pending board edits from WiFi (FEN-based)
   String editFen;
   if (wifiManager.getPendingBoardEdit(editFen)) {

src/wifi_manager_esp32.cpp

@@ -10,7 +10,7 @@
 
 static const char* INITIAL_FEN = "rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1";
 
-WiFiManagerESP32::WiFiManagerESP32(BoardDriver* bd, MoveHistory* mh) : boardDriver(bd), moveHistory(mh), server(AP_PORT), wifiSSID(SECRET_SSID), wifiPassword(SECRET_PASS), gameMode("0"), lichessToken(""), botConfig(), scanAllChannels(WIFI_SCAN_ALL_CHANNELS), currentFen(INITIAL_FEN), hasPendingEdit(false), boardEvaluation(0.0f), otaUpdater(bd), autoOtaEnabled(false) {}
+WiFiManagerESP32::WiFiManagerESP32(BoardDriver* bd, MoveHistory* mh) : boardDriver(bd), moveHistory(mh), server(AP_PORT), wifiSSID(SECRET_SSID), wifiPassword(SECRET_PASS), gameMode("0"), lichessToken(""), botConfig(), scanAllChannels(WIFI_SCAN_ALL_CHANNELS), currentFen(INITIAL_FEN), hasPendingEdit(false), hasPendingWiFi(false), boardEvaluation(0.0f), otaUpdater(bd), autoOtaEnabled(false) {}
 
 void WiFiManagerESP32::begin() {
   Serial.println("=== Starting OpenChess WiFi Manager (ESP32) ===");
@@ -159,32 +159,23 @@ void WiFiManagerESP32::handleConnectWiFi(AsyncWebServerRequest* request) {
         prefs.end();
         scanAllChannels = newScanAll;
         Serial.printf("WiFi scan all channels: %s\n", scanAllChannels ? "enabled" : "disabled");
-        request->send(200, "text/plain", "OK");
         changed = true;
       }
     }
   }
 
   if (newWifiSSID.length() >= 1 && newWifiPassword.length() >= 5 && (newWifiSSID != wifiSSID || newWifiPassword != wifiPassword)) {
-    if (!changed) {
-      request->send(200, "text/plain", "OK");
-      changed = true;
-    }
-    if (connectToWiFi(newWifiSSID, newWifiPassword, true)) {
-      if (!ChessUtils::ensureNvsInitialized())
-        Serial.println("NVS init failed - WiFi credentials not saved");
-      prefs.begin("wifiCreds", false);
-      prefs.putString("ssid", newWifiSSID);
-      prefs.putString("pass", newWifiPassword);
-      prefs.end();
-      wifiSSID = newWifiSSID;
-      wifiPassword = newWifiPassword;
-      Serial.println("WiFi credentials updated and saved to NVS");
-    }
-    return;
+    // Defer WiFi reconnection to the main loop to avoid blocking the async_tcp
+    // task, which would trigger the ESP32 task watchdog (WDT).
+    pendingWiFiSSID = newWifiSSID;
+    pendingWiFiPassword = newWifiPassword;
+    hasPendingWiFi = true;
+    changed = true;
   }
 
-  if (!changed)
+  if (changed)
+    request->send(200, "text/plain", "OK");
+  else
     request->send(400, "text/plain", "ERROR");
 }
 
@@ -400,6 +391,25 @@ void WiFiManagerESP32::clearPendingEdit() {
   hasPendingEdit = false;
 }
 
+void WiFiManagerESP32::checkPendingWiFi() {
+  if (!hasPendingWiFi)
+    return;
+  hasPendingWiFi = false;
+  String newSSID = pendingWiFiSSID;
+  String newPass = pendingWiFiPassword;
+  if (connectToWiFi(newSSID, newPass, true)) {
+    if (!ChessUtils::ensureNvsInitialized())
+      Serial.println("NVS init failed - WiFi credentials not saved");
+    prefs.begin("wifiCreds", false);
+    prefs.putString("ssid", newSSID);
+    prefs.putString("pass", newPass);
+    prefs.end();
+    wifiSSID = newSSID;
+    wifiPassword = newPass;
+    Serial.println("WiFi credentials updated and saved to NVS");
+  }
+}
+
 bool WiFiManagerESP32::connectToWiFi(const String& ssid, const String& password, bool fromWeb) {
   if (!fromWeb && WiFi.status() == WL_CONNECTED) {
     Serial.println("Already connected to WiFi");

src/wifi_manager_esp32.h

@@ -54,6 +54,11 @@ class WiFiManagerESP32 {
   String pendingFenEdit;
   bool hasPendingEdit;
 
+  // Deferred WiFi reconnection (set by web handler, processed in main loop)
+  String pendingWiFiSSID;
+  String pendingWiFiPassword;
+  volatile bool hasPendingWiFi;
+
   // Web interface methods
   String getWiFiInfoJSON();
   String getBoardUpdateJSON();
@@ -117,6 +122,8 @@ class WiFiManagerESP32 {
   void clearPendingEdit();
   // WiFi connection management
   bool connectToWiFi(const String& ssid, const String& password, bool fromWeb = false);
+  // Call from main loop to process deferred WiFi reconnection
+  void checkPendingWiFi();
 };
 
 #endif // WIFI_MANAGER_ESP32_H