PRO-14812 fix: skipped tests should be failed in Playwright

Author: uid11

autotests/pageObjects/pages/Main.ts

@@ -70,14 +70,17 @@ export class Main extends Page<CustomPageParams> {
     await this.waitForDomContentLoaded();
 
     await waitForAllRequestsComplete(
+      // eslint-disable-next-line complexity
       ({url}) => {
         if (
           url.startsWith('https://assets.msn.com/') ||
           url.startsWith('https://www.bing.com/ipv6test/') ||
           url.startsWith('https://www2.bing.com/ipv6test/') ||
           url.startsWith('https://browser.events.data.msn.com/') ||
           url.startsWith('https://img-s-msn-com.akamaized.net/') ||
+          url.startsWith('https://login.microsoftonline.com/') ||
           url.startsWith('https://rewards.bing.com/widget/') ||
+          url.startsWith('https://scripts.clarity.ms/') ||
           url.startsWith('https://th.bing.com/th?id=') ||
           url.startsWith('https://www.bing.com/th?id=')
         ) {
@@ -86,7 +89,10 @@ export class Main extends Page<CustomPageParams> {
 
         return true;
       },
-      {maxIntervalBetweenRequestsInMs: this.maxIntervalBetweenRequestsInMs, timeout: 8_000},
+      {
+        maxIntervalBetweenRequestsInMs: this.maxIntervalBetweenRequestsInMs,
+        timeout: Main.navigationTimeout,
+      },
     );
   }
 }

autotests/tests/main/exists.ts

@@ -20,7 +20,7 @@ import {assertFunctionThrows, getDocumentUrl} from 'e2ed/utils';
 import type {Url} from 'e2ed/types';
 
 // eslint-disable-next-line max-statements
-test('exists', {meta: {testId: '1'}, testIdleTimeout: 10_000, testTimeout: 15_000}, async () => {
+test('exists', {meta: {testId: '1'}, testIdleTimeout: 10_000, testTimeout: 20_000}, async () => {
   const language = 'en';
   const searchQuery = 'foo';
   const testScrollValue = 200;

src/utils/test/afterTest.ts

@@ -1,6 +1,7 @@
+import {TestRunStatus} from '../../constants/internal';
 import {getClearPage} from '../../context/clearPage';
 
-import {registerEndTestRunEvent} from '../events';
+import {getTestRunEvent, registerEndTestRunEvent} from '../events';
 import {generalLog, writeLogsToFile} from '../generalLog';
 
 import type {EndTestRunEvent, UtcTimeInMs} from '../../types/internal';
@@ -27,5 +28,12 @@ export const afterTest = async (options: Options): Promise<void> => {
     await writeLogsToFile();
 
     throw error;
+  } finally {
+    const testRunEvent = getTestRunEvent(options.runId);
+
+    if (testRunEvent.status === TestRunStatus.Skipped) {
+      // eslint-disable-next-line no-unsafe-finally
+      throw new Error(`Skipped test "${testRunEvent.name}" should be failed in Playwright`);
+    }
   }
 };

src/utils/test/beforeTest.ts

@@ -77,7 +77,6 @@ export const beforeTest = ({
   const {onlog, reject, testFnWithReject} = getTestFnAndReject({
     isSkipped,
     runId,
-    skipReason,
     testFn,
     testIdleTimeout,
     testTimeout,

src/utils/test/getTestFnAndReject.ts

@@ -8,12 +8,9 @@ import {getPromiseWithResolveAndReject} from '../promise';
 
 import type {Onlog, RejectTestRun, RunId, TestFn, Void} from '../../types/internal';
 
-import {test as playwrightTest} from '@playwright/test';
-
 type Options = Readonly<{
   isSkipped: boolean;
   runId: RunId;
-  skipReason: string | undefined;
   testFn: TestFn;
   testIdleTimeout: number;
   testTimeout: number;
@@ -29,7 +26,6 @@ type Return = Readonly<{onlog: Onlog; reject: RejectTestRun; testFnWithReject: T
 export const getTestFnAndReject = ({
   isSkipped,
   runId,
-  skipReason,
   testFn,
   testIdleTimeout,
   testTimeout,
@@ -38,13 +34,7 @@ export const getTestFnAndReject = ({
     return {
       onlog: () => undefined,
       reject: () => undefined,
-      testFnWithReject: () => {
-        try {
-          playwrightTest.skip(true, skipReason);
-        } catch {}
-
-        return RESOLVED_PROMISE;
-      },
+      testFnWithReject: () => RESOLVED_PROMISE,
     };
   }