Add OutputFilter::escapeCsvFormula#88
Open
arib06 wants to merge 1 commit into
Open
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a shared
escapeCsvFormula()method toOutputFilter.A value beginning with
=,+,-or@that is written into a CSV file is evaluated as a formula when the file is opened directly in a spreadsheet application (CSV formula injection, CWE-1236). Prepending a space keeps the value inert while leaving it readable.The CMS currently implements this twice, in
ActionlogsHelperand (pending in joomla/joomla-cms#48047) in the banner tracks export. Per the discussion on that PR the shared implementation belongs in the framework filter package rather than the CMSOutputFilter, so that the CMS can move both call sites onto it in 6.2 and third party extensions can use it too.Unit tests covering the formula characters, an inner
=, plain text and the empty string are included inTests/OutputFilterTest.php.Related: joomla/joomla-cms#48047