Merge pull request #66 from joomla-framework/fix-phpstan-errors

Fix some errors

Author: richard67

phpstan-baseline.neon

@@ -0,0 +1,43 @@
+parameters:
+	ignoreErrors:
+		-
+			message: '#^Instanceof between ArrayAccess and ArrayAccess will always evaluate to true\.$#'
+			identifier: instanceof.alwaysTrue
+			count: 1
+			path: src/AbstractTransport.php
+
+		-
+			message: '#^Result of && is always false\.$#'
+			identifier: booleanAnd.alwaysFalse
+			count: 1
+			path: src/AbstractTransport.php
+
+		-
+			message: '#^Instanceof between ArrayAccess and ArrayAccess will always evaluate to true\.$#'
+			identifier: instanceof.alwaysTrue
+			count: 1
+			path: src/Http.php
+
+		-
+			message: '#^Instanceof between Joomla\\Uri\\UriInterface and Joomla\\Uri\\UriInterface will always evaluate to true\.$#'
+			identifier: instanceof.alwaysTrue
+			count: 1
+			path: src/Http.php
+
+		-
+			message: '#^Result of && is always false\.$#'
+			identifier: booleanAnd.alwaysFalse
+			count: 1
+			path: src/Http.php
+
+		-
+			message: '#^Instanceof between ArrayAccess and ArrayAccess will always evaluate to true\.$#'
+			identifier: instanceof.alwaysTrue
+			count: 2
+			path: src/HttpFactory.php
+
+		-
+			message: '#^Result of && is always false\.$#'
+			identifier: booleanAnd.alwaysFalse
+			count: 2
+			path: src/HttpFactory.php

phpstan.neon

@@ -1,5 +1,6 @@
 
 includes:
+	- phpstan-baseline.neon
 	- vendor/phpstan/phpstan-deprecation-rules/rules.neon
 
 parameters:

src/Transport/Socket.php

@@ -286,6 +286,6 @@ protected function connect(UriInterface $uri, $timeout = null)
      */
     public static function isSupported()
     {
-        return \function_exists('fsockopen') && \is_callable('fsockopen');
+        return \function_exists('fsockopen');
     }
 }

src/Transport/Stream.php

@@ -258,6 +258,6 @@ protected function getResponse(array $headers, $body)
      */
     public static function isSupported()
     {
-        return \function_exists('fopen') && \is_callable('fopen') && ini_get('allow_url_fopen');
+        return \function_exists('fopen') && ini_get('allow_url_fopen');
     }
 }