Skip to content

Custom/add buffer observer#120

Open
cendolinside123 wants to merge 5 commits into
jorgenhenrichsen:masterfrom
cendolinside123:custom/add-buffer-Observer
Open

Custom/add buffer observer#120
cendolinside123 wants to merge 5 commits into
jorgenhenrichsen:masterfrom
cendolinside123:custom/add-buffer-Observer

Conversation

@cendolinside123
Copy link
Copy Markdown

@cendolinside123 cendolinside123 commented Jul 2, 2020

create observable for bufferedPosition so player can get the info about time ranges indicating media data that is readily available every time bufferedPosition has a new value (note: it still update the buffer even though player pause the song, to make this work like how buffer indicator load buffered duration on youtube)

	- AVPlayerObserver:
		- remove proces observing loadedTimeRange because it already do on AVPlayerItemObserver
		- remove protocol AVPlayerObserveBufferDelegate
	- AVPlayerItemObserver:
		- add new method getBufferPosition(buffer: Double) on protocol AVPlayerItemObserverDelegate
	- AVPlayerWrapper:
		- remove implementation of AVPlayerObserveBufferDelegate
		- implement getBufferPosition(buffer: Double) from protocol AVPlayerItemObserverDelegate
	- AVPlayerItemObserverTests:
		- implement getBufferPosition(buffer: Double) from protocol AVPlayerItemObserverDelegate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant