soap: do not overwrite the parsed host on a protocol-relative redirect#29
Closed
jorgsowa wants to merge 3 commits into
Closed
soap: do not overwrite the parsed host on a protocol-relative redirect#29jorgsowa wants to merge 3 commits into
jorgsowa wants to merge 3 commits into
Conversation
When a redirect Location is a protocol-relative reference (//host/path), php_url_parse() already fills new_url->host, but the scheme-less redirect handling overwrote it with a copy of the request host without releasing the parsed one. That leaks a zend_string per such redirect and pins the redirect back to the original host instead of the one the server named. Inherit host and port from the request URL only when new_url->host is NULL, mirroring the scheme guard directly above. Closes phpGH-22434
The nightly COMMUNITY_asan job hangs every run in the Symfony Console OutputFormatter tests (test php#672, testInlineStyle) under tracing JIT, exhausting GitHub's 6h ceiling. The hang is an x86-64 tracing-JIT regression present in 8.4/8.5/8.6 but not 8.3, and does not reproduce on ARM or under qemu emulation. Add a manually-triggered bisect that runs on a native x86-64 runner, building ZTS+JIT+ASAN (matching COMMUNITY_asan) and using a Console-suite hang as the bisect signal, to pinpoint the introducing commit.
Run the bisect automatically when a PR is opened/reopened, using the default good/bad/symfony bounds (inputs fall back to defaults since pull_request runs carry no workflow_dispatch inputs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.