Skip to content

Commit 9f4300a

Browse files
jpeimerjosemacassan
authored andcommitted
[4.22] [Storage] Remove jira CNV-88758 from hotplug tests (RedHatQE#5190)
##### What this PR does / why we need it: The Jira is resolved, so remove the conditional memory/CPU override in `fedora_vm_for_hotplug_scope_class` fixture and clean up unused imports. Assisted-by: Claude <noreply@anthropic.com> ##### Which issue(s) this PR fixes: ##### Special notes for reviewer: ##### jira-ticket: <!-- full-ticket-url needs to be provided. This would add a link to the pull request to the jira and close it when the pull request is merged If the task is not tracked by a Jira ticket, just write "NONE". --> Signed-off-by: Jenia Peimer <jpeimer@redhat.com> Signed-off-by: Jose Manuel Castano <joscasta@redhat.com>
1 parent 483ce54 commit 9f4300a

1 file changed

Lines changed: 1 addition & 12 deletions

File tree

tests/storage/test_hotplug.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@
1212

1313
from tests.storage.utils import assert_disk_bus
1414
from tests.utils import create_windows2022_dv_from_registry, create_windows2022_vm_with_vtpm_from_registry
15-
from utilities.constants import HOTPLUG_DISK_SCSI_BUS, HOTPLUG_DISK_SERIAL, HOTPLUG_DISK_VIRTIO_BUS, Images
15+
from utilities.constants import HOTPLUG_DISK_SCSI_BUS, HOTPLUG_DISK_SERIAL, HOTPLUG_DISK_VIRTIO_BUS
1616
from utilities.hco import ResourceEditorValidateHCOReconcile
17-
from utilities.jira import is_jira_open
1817
from utilities.storage import (
1918
assert_disk_serial,
2019
assert_hotplugvolume_nonexist,
@@ -129,23 +128,13 @@ def param_substring_scope_class(storage_class_name_scope_class):
129128
@pytest.fixture(scope="class")
130129
def fedora_vm_for_hotplug_scope_class(unprivileged_client, namespace, param_substring_scope_class, cpu_for_migration):
131130
name = f"fedora-hotplug-{param_substring_scope_class}"
132-
memory_requests = None
133-
cpu_requests = None
134-
135-
if is_jira_open(jira_id="CNV-88758"):
136-
memory_requests = f"{float(Images.Fedora.DEFAULT_MEMORY_SIZE[:-2]) * 2}Gi"
137-
cpu_requests = 1
138131

139132
with VirtualMachineForTests(
140133
client=unprivileged_client,
141134
name=name,
142-
memory_requests=memory_requests,
143-
memory_limits=memory_requests,
144135
namespace=namespace.name,
145136
body=fedora_vm_body(name=name),
146137
cpu_model=cpu_for_migration,
147-
cpu_limits=cpu_requests,
148-
cpu_requests=cpu_requests,
149138
) as vm:
150139
running_vm(vm=vm)
151140
yield vm

0 commit comments

Comments
 (0)