Skip to content

Commit acab790

Browse files
committed
refactor(angular): remove (basic) suffix from v0.8 basic tests
Remove the redundant '(basic)' suffix from the 28 basic v0.8 test files (both describe block and loadExample calls), as the minimal catalog is no longer used in renderers. Also: - Remove the suffix logic from generate-examples.mjs for v0.8. - Remove the fallback logic from test_utils.ts. TAG=agy CONV=9137c307-af0d-4380-8e89-52054dd1fcb0
1 parent d9fdb28 commit acab790

30 files changed

Lines changed: 59 additions & 68 deletions

renderers/angular/a2ui_explorer/src/app/tests/utils/test_utils.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,7 @@ export async function loadExample(exampleName: string, version: Version = Versio
4343
fixture.detectChanges();
4444

4545
const examples = version === Version.V0_9 ? EXAMPLES_V09 : EXAMPLES_V08;
46-
let example = examples.find(ex => ex.name === exampleName);
47-
48-
if (version === Version.V0_8 && !example) {
49-
example =
50-
examples.find(ex => ex.name === `${exampleName} (basic)`) ||
51-
examples.find(ex => ex.name === `${exampleName} (minimal)`);
52-
}
46+
const example = examples.find(ex => ex.name === exampleName);
5347

5448
expect(example).withContext(`Example not found: ${exampleName}`).toBeTruthy();
5549

renderers/angular/a2ui_explorer/src/app/tests/v0_8/03_calendar-day.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ import {ComponentFixture} from '@angular/core/testing';
1818
import {DemoComponent} from '../../demo.component';
1919
import {Version, getCanvas, loadExample, wait} from '../utils/test_utils';
2020

21-
describe('Example: Calendar Day (basic) (v0.8)', () => {
21+
describe('Example: Calendar Day (v0.8)', () => {
2222
let textContent: string;
2323
let fixture: ComponentFixture<DemoComponent>;
2424

2525
beforeEach(async () => {
26-
fixture = await loadExample('Calendar Day (basic)', Version.V0_8);
26+
fixture = await loadExample('Calendar Day', Version.V0_8);
2727
textContent = getCanvas().textContent;
2828
});
2929

renderers/angular/a2ui_explorer/src/app/tests/v0_8/04_weather-current.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616

1717
import {Version, getCanvas, loadExample} from '../utils/test_utils';
1818

19-
describe('Example: Weather Current (basic) (v0.8)', () => {
19+
describe('Example: Weather Current (v0.8)', () => {
2020
let textContent: string;
2121

2222
beforeEach(async () => {
23-
await loadExample('Weather Current (basic)', Version.V0_8);
23+
await loadExample('Weather Current', Version.V0_8);
2424
textContent = getCanvas().textContent;
2525
});
2626

renderers/angular/a2ui_explorer/src/app/tests/v0_8/05_product-card.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ import {ComponentFixture} from '@angular/core/testing';
1818
import {DemoComponent} from '../../demo.component';
1919
import {Version, getCanvas, loadExample, wait} from '../utils/test_utils';
2020

21-
describe('Example: Product Card (basic) (v0.8)', () => {
21+
describe('Example: Product Card (v0.8)', () => {
2222
let textContent: string;
2323
let fixture: ComponentFixture<DemoComponent>;
2424

2525
beforeEach(async () => {
26-
fixture = await loadExample('Product Card (basic)', Version.V0_8);
26+
fixture = await loadExample('Product Card', Version.V0_8);
2727
textContent = getCanvas().textContent;
2828
});
2929

renderers/angular/a2ui_explorer/src/app/tests/v0_8/06_music-player.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ import {ComponentFixture} from '@angular/core/testing';
1818
import {DemoComponent} from '../../demo.component';
1919
import {Version, getCanvas, loadExample, wait} from '../utils/test_utils';
2020

21-
describe('Example: Music Player (basic) (v0.8)', () => {
21+
describe('Example: Music Player (v0.8)', () => {
2222
let textContent: string;
2323
let fixture: ComponentFixture<DemoComponent>;
2424

2525
beforeEach(async () => {
26-
fixture = await loadExample('Music Player (basic)', Version.V0_8);
26+
fixture = await loadExample('Music Player', Version.V0_8);
2727
textContent = getCanvas().textContent;
2828
});
2929

renderers/angular/a2ui_explorer/src/app/tests/v0_8/07_task-card.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616

1717
import {Version, getCanvas, loadExample} from '../utils/test_utils';
1818

19-
describe('Example: Task Card (basic) (v0.8)', () => {
19+
describe('Example: Task Card (v0.8)', () => {
2020
let textContent: string;
2121

2222
beforeEach(async () => {
23-
await loadExample('Task Card (basic)', Version.V0_8);
23+
await loadExample('Task Card', Version.V0_8);
2424
textContent = getCanvas().textContent;
2525
});
2626

renderers/angular/a2ui_explorer/src/app/tests/v0_8/08_user-profile.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ import {ComponentFixture} from '@angular/core/testing';
1818
import {DemoComponent} from '../../demo.component';
1919
import {Version, getCanvas, loadExample, wait} from '../utils/test_utils';
2020

21-
describe('Example: User Profile (basic) (v0.8)', () => {
21+
describe('Example: User Profile (v0.8)', () => {
2222
let textContent: string;
2323
let fixture: ComponentFixture<DemoComponent>;
2424

2525
beforeEach(async () => {
26-
fixture = await loadExample('User Profile (basic)', Version.V0_8);
26+
fixture = await loadExample('User Profile', Version.V0_8);
2727
textContent = getCanvas().textContent;
2828
});
2929

renderers/angular/a2ui_explorer/src/app/tests/v0_8/09_login-form.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ import {ComponentFixture} from '@angular/core/testing';
1818
import {DemoComponent} from '../../demo.component';
1919
import {Version, getCanvas, loadExample, wait} from '../utils/test_utils';
2020

21-
describe('Example: Login Form (basic) (v0.8)', () => {
21+
describe('Example: Login Form (v0.8)', () => {
2222
let textContent: string;
2323
let fixture: ComponentFixture<DemoComponent>;
2424

2525
beforeEach(async () => {
26-
fixture = await loadExample('Login Form (basic)', Version.V0_8);
26+
fixture = await loadExample('Login Form', Version.V0_8);
2727
textContent = getCanvas().textContent;
2828
});
2929

renderers/angular/a2ui_explorer/src/app/tests/v0_8/10_notification-permission.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ import {ComponentFixture} from '@angular/core/testing';
1818
import {DemoComponent} from '../../demo.component';
1919
import {Version, getCanvas, loadExample, wait} from '../utils/test_utils';
2020

21-
describe('Example: Notification Permission (basic) (v0.8)', () => {
21+
describe('Example: Notification Permission (v0.8)', () => {
2222
let textContent: string;
2323
let fixture: ComponentFixture<DemoComponent>;
2424

2525
beforeEach(async () => {
26-
fixture = await loadExample('Notification Permission (basic)', Version.V0_8);
26+
fixture = await loadExample('Notification Permission', Version.V0_8);
2727
textContent = getCanvas().textContent;
2828
});
2929

renderers/angular/a2ui_explorer/src/app/tests/v0_8/11_purchase-complete.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ import {ComponentFixture} from '@angular/core/testing';
1818
import {DemoComponent} from '../../demo.component';
1919
import {Version, getCanvas, loadExample, wait} from '../utils/test_utils';
2020

21-
describe('Example: Purchase Complete (basic) (v0.8)', () => {
21+
describe('Example: Purchase Complete (v0.8)', () => {
2222
let textContent: string;
2323
let fixture: ComponentFixture<DemoComponent>;
2424

2525
beforeEach(async () => {
26-
fixture = await loadExample('Purchase Complete (basic)', Version.V0_8);
26+
fixture = await loadExample('Purchase Complete', Version.V0_8);
2727
textContent = getCanvas().textContent;
2828
});
2929

0 commit comments

Comments
 (0)