Skip to content

Commit e8dce3b

Browse files
authored
fix(angular): expose checks type in ExtendedProps (a2ui-project#1523)
This exposes the checks type that is currently present in the resulting object from the binder. This is needed because I found a 1P component relying on this type.
1 parent 734b801 commit e8dce3b

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

renderers/angular/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
- (v0_8) Fix Icon component to handle camelCase and TitleCase names by converting them to snake_case for `g-icon`.
55
- (v0_8) Fix Modal component styling and position fixed for overlay.
66
- (v0_9) Remove `placeholder` prop support from the `TextField` component, since it was not part of the v0_9 basic catalog schema. [#1372](https://github.com/google/A2UI/pull/1372)
7+
- (v0_9) Preserve `checks` property in `ExtendedProps` type. [#1523](https://github.com/google/A2UI/pull/1523)
78

89
## 0.10.0
910

renderers/angular/src/v0_9/core/types.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,7 @@ interface CheckProps {
8282

8383
/** The binder can add some properties to the Props object. This util adds them to the type. */
8484
export type ExtendedProps<ComponentProps extends {[key: string]: unknown}> =
85-
'checks' extends keyof ComponentProps
86-
? Omit<ComponentProps, 'checks'> & CheckProps
87-
: ComponentProps;
85+
'checks' extends keyof ComponentProps ? ComponentProps & CheckProps : ComponentProps;
8886

8987
/**
9088
* Utility to convert a component Api Type to the props Type, where the

0 commit comments

Comments
 (0)