Propose MIT license and refresh README#15
Closed
hvboq wants to merge 1 commit into
Closed
Conversation
Author
|
Update: this change has also been merged into the hvboq fork's master branch for immediate use there. The upstream PR remains open and ready for review to propose adopting the MIT License and the README improvements in the original repository. |
Author
|
Superseded by #14. The MIT license proposal and README refresh have been folded into the existing LM Studio PR, so this separate PR is being closed to avoid duplicate review. |
Author
|
Closing as superseded by #14, which now includes these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes adopting the MIT License for this repository and refreshes the README so users can understand the project setup more easily.
Changes included:
LICENSEfile usingjoshfreitas1984 and contributorsas the copyright holder line.PackageLicenseExpression=MITto the plugin project metadata.Why
The upstream repository currently does not expose a detected license through GitHub metadata. Adding an explicit license removes ambiguity for users and contributors about allowed use, modification, and redistribution.
Validation
git diff --checkpassed with no whitespace errors.dotnet build XUnity.AutoTranslate.LlmTranslators.sln -c Debugpassed.Known existing issues observed while validating:
dotnet build XUnity.AutoTranslate.LlmTranslators.sln -c Releasecurrently fails in the existingILRepack.MSBuild.Taskmerge step on the local .NET SDK.dotnet test XUnity.AutoTranslate.LlmTranslators.sln -c Debug --no-buildcurrently fails because one prompt fixture is missing underTestOutputand the Ollama prompt test expects a local Ollama server onlocalhost:11434.YamlDotNet 4.2.1.