Merge pull request dbt-msft#709 from dbt-msft/FIX/444-wrong-commit-post-hook

fix: guard run_hooks commit with @@trancount check for autocommit safety

Author: axellpadilla

dbt/include/sqlserver/macros/materializations/hooks.sql

@@ -0,0 +1,15 @@
+{% macro run_hooks(hooks, inside_transaction=True) %}
+  {% for hook in hooks | selectattr('transaction', 'equalto', inside_transaction)  %}
+    {% if not inside_transaction and loop.first %}
+      {% call statement(auto_begin=inside_transaction) %}
+        if @@trancount > 0 commit;
+      {% endcall %}
+    {% endif %}
+    {% set rendered = render(hook.get('sql')) | trim %}
+    {% if (rendered | length) > 0 %}
+      {% call statement(auto_begin=inside_transaction) %}
+        {{ rendered }}
+      {% endcall %}
+    {% endif %}
+  {% endfor %}
+{% endmacro %}

tests/functional/adapter/dbt/test_hooks.py

@@ -232,3 +232,28 @@ def test_pre_post_model_hooks_refed(self, project, dbt_profile_target):
 
 class TestHookRefs(BaseHookRefs):
     pass
+
+
+class BaseAfterCommitModelHook(BaseTestPrePost):
+    @pytest.fixture(scope="class")
+    def project_config_update(self):
+        return {
+            "models": {
+                "test": {
+                    "post-hook": [
+                        {"sql": "select 1", "transaction": False},
+                    ],
+                }
+            }
+        }
+
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {"after_commit_hook_model.sql": "select 1 as id"}
+
+    def test_after_commit_post_hook_does_not_double_commit(self, project):
+        run_dbt()
+
+
+class TestAfterCommitModelHook(BaseAfterCommitModelHook):
+    pass