fix: use self.execute_command to avoid docker docker bug (#180)

* fix: use self.execute_command to avoid docker docker bug

Commands were incorrectly calling self.executor.execute_command("docker", args)
which resulted in 'docker docker <cmd>' being executed. This fixes all 10
affected commands to use self.execute_command(args) instead.

Also adds a CI check to prevent this antipattern from reoccurring.

Fixes #176

* fix: address clippy unnecessary_unwrap warnings in tests

---------

Co-authored-by: KrLite <wang070621@foxmail.com>

Author: joshrotenberg

.github/workflows/ci.yml

@@ -46,6 +46,17 @@ jobs:
         if: matrix.rust == 'stable' && matrix.os == 'ubuntu-latest'
         run: cargo fmt -- --check
 
+      - name: Check for executor.execute_command antipattern
+        if: matrix.rust == 'stable' && matrix.os == 'ubuntu-latest'
+        run: |
+          # Commands should use self.execute_command(args) not self.executor.execute_command("docker", args)
+          # The latter causes "docker docker <cmd>" double-command bug
+          if grep -r 'executor\.execute_command("docker"' src/command/; then
+            echo "ERROR: Found executor.execute_command(\"docker\", ...) antipattern!"
+            echo "Use self.execute_command(args) instead to avoid 'docker docker' bug."
+            exit 1
+          fi
+
       - name: Run Clippy
         if: matrix.rust == 'stable'
         run: cargo clippy --all-targets --all-features -- -D warnings

src/command/build.rs

@@ -1034,7 +1034,7 @@ impl BuildCommand {
         &self.executor
     }
 
-    /// Get a mutable reference to the command executor  
+    /// Get a mutable reference to the command executor
     #[must_use]
     pub fn get_executor_mut(&mut self) -> &mut CommandExecutor {
         &mut self.executor
@@ -1322,7 +1322,7 @@ impl DockerCommand for BuildCommand {
 
     async fn execute(&self) -> Result<Self::Output> {
         let args = self.build_command_args();
-        let output = self.executor.execute_command("docker", args).await?;
+        let output = self.execute_command(args).await?;
 
         // Extract image ID from output
         let image_id = if self.quiet {

src/command/builder/build.rs

@@ -165,7 +165,7 @@ impl DockerCommand for BuilderBuildCommand {
     async fn execute(&self) -> Result<Self::Output> {
         // The builder build command has the same output as regular build
         let args = self.build_command_args();
-        let output = self.inner.executor.execute_command("docker", args).await?;
+        let output = self.execute_command(args).await?;
 
         // Extract image ID from output
         let image_id = extract_image_id(&output.stdout);

src/command/builder/prune.rs

@@ -191,7 +191,7 @@ impl DockerCommand for BuilderPruneCommand {
 
     async fn execute(&self) -> Result<Self::Output> {
         let args = self.build_command_args();
-        let output = self.executor.execute_command("docker", args).await?;
+        let output = self.execute_command(args).await?;
 
         let (deleted_cache_ids, space_reclaimed, space_reclaimed_str) =
             Self::parse_output(&output.stdout);

src/command/images.rs

@@ -820,7 +820,7 @@ impl DockerCommand for ImagesCommand {
 
     async fn execute(&self) -> Result<Self::Output> {
         let args = self.build_command_args();
-        let output = self.executor.execute_command("docker", args).await?;
+        let output = self.execute_command(args).await?;
 
         let images = self.parse_output(&output);
 

src/command/login.rs

@@ -234,7 +234,7 @@ impl DockerCommand for LoginCommand {
 
     async fn execute(&self) -> Result<Self::Output> {
         let args = self.build_command_args();
-        let output = self.executor.execute_command("docker", args).await?;
+        let output = self.execute_command(args).await?;
 
         Ok(LoginOutput { output })
     }

src/command/logout.rs

@@ -186,7 +186,7 @@ impl DockerCommand for LogoutCommand {
 
     async fn execute(&self) -> Result<Self::Output> {
         let args = self.build_command_args();
-        let output = self.executor.execute_command("docker", args).await?;
+        let output = self.execute_command(args).await?;
 
         Ok(LogoutOutput { output })
     }

src/command/pull.rs

@@ -349,7 +349,7 @@ impl DockerCommand for PullCommand {
 
     async fn execute(&self) -> Result<Self::Output> {
         let args = self.build_command_args();
-        self.executor.execute_command("docker", args).await
+        self.execute_command(args).await
     }
 }
 

src/command/push.rs

@@ -357,7 +357,7 @@ impl DockerCommand for PushCommand {
 
     async fn execute(&self) -> Result<Self::Output> {
         let args = self.build_command_args();
-        self.executor.execute_command("docker", args).await
+        self.execute_command(args).await
     }
 }
 

src/command/search.rs

@@ -488,7 +488,7 @@ impl DockerCommand for SearchCommand {
 
     async fn execute(&self) -> Result<Self::Output> {
         let args = self.build_command_args();
-        let output = self.executor.execute_command("docker", args).await?;
+        let output = self.execute_command(args).await?;
 
         let repositories = self.parse_output(&output)?;