fix: use self.execute_command to avoid docker docker bug#180
Merged
joshrotenberg merged 2 commits intomainfrom Dec 11, 2025
Merged
fix: use self.execute_command to avoid docker docker bug#180joshrotenberg merged 2 commits intomainfrom
joshrotenberg merged 2 commits intomainfrom
Conversation
Commands were incorrectly calling self.executor.execute_command("docker", args)
which resulted in 'docker docker <cmd>' being executed. This fixes all 10
affected commands to use self.execute_command(args) instead.
Also adds a CI check to prevent this antipattern from reoccurring.
Fixes #176
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commands were incorrectly calling
self.executor.execute_command("docker", args)which resulted indocker docker <cmd>being executed. This fixes all 10 affected commands to useself.execute_command(args)instead.Affected Commands
Prevention
Added a CI check that greps for this antipattern to prevent it from happening again.
Attribution
Based on the fix identified by @KrLite in #177.
Fixes #176