deps: Bump Microsoft.Identity.Client and Microsoft.Identity.Client.Extensions.Msal#1299
Merged
Merged
Conversation
…tensions.Msal Bumps Microsoft.Identity.Client from 4.84.2 to 4.85.2 Bumps Microsoft.Identity.Client.Extensions.Msal from 4.84.2 to 4.85.2 --- updated-dependencies: - dependency-name: Microsoft.Identity.Client dependency-version: 4.85.2 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Microsoft.Identity.Client.Extensions.Msal dependency-version: 4.85.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
dependabot
Bot
added
the
dependencies
joshsmithxrm
added a commit
that referenced
this pull request
Jul 11, 2026
…lint tooling Two more classifier gaps surfaced by the same /dependabot-triage run, folded into this branch. Gap 1 — multi-package titles (real PR #1299): A title like "Bump Microsoft.Identity.Client and Microsoft.Identity.Client.Extensions.Msal" carries no version, so parse_title() returns (None, None, None), update_type becomes "unknown", and classify_pr() fell through to the Group-C "could not classify" default. But the body enumerates each member ("Updated [pkg](url) from A to B") — both auth-critical MINOR bumps that per docs/MERGE-POLICY.md are Group B (verify-then-merge), not C. Fix: when the single-title parse yields no package and the title is not a "group:" title, attempt parse_group_members(body); if it finds >=1 members, run them through the SAME per-member most-conservative-wins logic the grouped path uses. Factored that block out of the grouped branch into a shared _classify_member_set() helper so both the "group:" path and the new multi-package path reuse it (no duplication). A genuinely unparseable PR (no title parse AND no body members) still hits the Group-C default. Normal single-package and "group:" PRs are unchanged. Gap 2 — stylelint missing from TOOLING_PACKAGES (real PR #1279): stylelint is a dev-time CSS linter (same class as eslint/knip/prettier), but its absence routed a stylelint minor bump to Group B instead of Group A. Added "stylelint" to the frozenset. Tests (tests/scripts/dependabot/test_classify.py): - multi-package auth-critical minor (#1299) -> Group B, reason names the auth-critical package - multi-package with a major member -> Group C (most-conservative-wins) - multi-package two non-critical patch members -> Group A - multi-package unparseable body -> Group C "could not classify" - stylelint minor (#1279) -> Group A (tooling) docs/MERGE-POLICY.md unchanged; neither change touches the auth-critical list, so TestAuthCriticalDocCodeDrift is unaffected. Full suite: 64 passed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
joshsmithxrm
added a commit
that referenced
this pull request
Jul 11, 2026
…tch, multi-package titles, stylelint tooling) (#1311) * fix(dependabot): route auth-critical patch bumps to Group B, not auto-merge Policy (docs/MERGE-POLICY.md "Auth-Critical Packages"): bumps to auth-critical packages at ANY non-major version go through Group B (verify-then-merge) — patch included. Bug: the single-PR path in classify_pr() gated the auth-critical override on `update_type == "minor"` only. An auth-critical PATCH bump therefore skipped the override and fell through to the generic `update_type == "patch"` branch, becoming Group A (auto-merge eligible) — exactly what the policy forbids. Caught on real PR #1288 (System.Security.Cryptography.Pkcs 10.0.5 -> 10.0.9, a crypto/auth package) via /dependabot-triage. Fix (one line): change the condition to `is_auth_critical_package(pkg) and update_type in ("patch", "minor")` and make the reason string interpolate the actual update_type instead of hard-coding "minor". Major already returns Group C earlier; an "unknown" update_type still falls through to the final Group-C manual-review default. The grouped-PR path (resolve_member_group) was already correct and is untouched. Tests: add regression coverage in test_classify.py — - auth-critical PATCH (Pkcs 10.0.5->10.0.9) -> Group B (was A) - auth-critical MAJOR (Identity.Client 4->5) still -> Group C Existing auth-critical minor -> B and non-auth-critical patch -> A remain green, including the TestAuthCriticalDocCodeDrift drift test. Full suite: 59 passed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(dependabot): parse multi-package "Bump X and Y" titles; add stylelint tooling Two more classifier gaps surfaced by the same /dependabot-triage run, folded into this branch. Gap 1 — multi-package titles (real PR #1299): A title like "Bump Microsoft.Identity.Client and Microsoft.Identity.Client.Extensions.Msal" carries no version, so parse_title() returns (None, None, None), update_type becomes "unknown", and classify_pr() fell through to the Group-C "could not classify" default. But the body enumerates each member ("Updated [pkg](url) from A to B") — both auth-critical MINOR bumps that per docs/MERGE-POLICY.md are Group B (verify-then-merge), not C. Fix: when the single-title parse yields no package and the title is not a "group:" title, attempt parse_group_members(body); if it finds >=1 members, run them through the SAME per-member most-conservative-wins logic the grouped path uses. Factored that block out of the grouped branch into a shared _classify_member_set() helper so both the "group:" path and the new multi-package path reuse it (no duplication). A genuinely unparseable PR (no title parse AND no body members) still hits the Group-C default. Normal single-package and "group:" PRs are unchanged. Gap 2 — stylelint missing from TOOLING_PACKAGES (real PR #1279): stylelint is a dev-time CSS linter (same class as eslint/knip/prettier), but its absence routed a stylelint minor bump to Group B instead of Group A. Added "stylelint" to the frozenset. Tests (tests/scripts/dependabot/test_classify.py): - multi-package auth-critical minor (#1299) -> Group B, reason names the auth-critical package - multi-package with a major member -> Group C (most-conservative-wins) - multi-package two non-critical patch members -> Group A - multi-package unparseable body -> Group C "could not classify" - stylelint minor (#1279) -> Group A (tooling) docs/MERGE-POLICY.md unchanged; neither change touches the auth-critical list, so TestAuthCriticalDocCodeDrift is unaffected. Full suite: 64 passed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(dependabot): apply breaking-change + auth-path guards to member-set path _classify_member_set() returned before changelog_signals_breaking(body) and touches_auth_critical_path(files) ran, so a grouped or multi-package Dependabot PR could be classified A/B and auto-merge despite a BREAKING CHANGE marker in the body or an auth-critical-path diff (e.g. src/PPDS.Auth/**). Thread body and files into _classify_member_set() and apply both as most-conservative overrides: a breaking marker forces Group C, an auth-critical-path diff escalates to at least Group B. Adds regression tests for grouped + multi-package breaking markers and member-set auth-path escalation. Found in CodeRabbit review of #1311. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Microsoft.Identity.Client from 4.84.2 to 4.85.2.
Release notes
Sourced from Microsoft.Identity.Client's releases.
4.85.2
What's Changed
Full Changelog: AzureAD/microsoft-authentication-library-for-dotnet@4.85.1...4.85.2
4.85.1
What's Changed
Full Changelog: AzureAD/microsoft-authentication-library-for-dotnet@4.85.0...4.85.1
4.85.0
What's Changed
New Contributors
Full Changelog: AzureAD/microsoft-authentication-library-for-dotnet@4.84.2...4.85.0
Commits viewable in compare view.
Updated Microsoft.Identity.Client.Extensions.Msal from 4.84.2 to 4.85.2.
Release notes
Sourced from Microsoft.Identity.Client.Extensions.Msal's releases.
4.85.2
What's Changed
Full Changelog: AzureAD/microsoft-authentication-library-for-dotnet@4.85.1...4.85.2
4.85.1
What's Changed
Full Changelog: AzureAD/microsoft-authentication-library-for-dotnet@4.85.0...4.85.1
4.85.0
What's Changed
New Contributors
Full Changelog: AzureAD/microsoft-authentication-library-for-dotnet@4.84.2...4.85.0
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)