Skip to content

Commit 4018cf8

Browse files
committed
Simplify node requirement
1 parent 5fa0449 commit 4018cf8

File tree

4 files changed

+1
-27
lines changed

4 files changed

+1
-27
lines changed

.github/actions/setup-node-pnpm/action.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@ name: Setup Node and pnpm
22
description: Setup pnpm, Node.js, and install project dependencies
33

44
inputs:
5-
node-architecture:
6-
description: Optional Node.js architecture passed to actions/setup-node
7-
required: false
8-
default: ""
95
registry-url:
106
description: Optional npm registry URL passed to actions/setup-node
117
required: false
@@ -28,7 +24,6 @@ runs:
2824
uses: actions/setup-node@v6
2925
with:
3026
node-version-file: .nvmrc
31-
architecture: ${{ inputs.node-architecture }}
3227
cache: pnpm
3328
registry-url: ${{ inputs.registry-url }}
3429

.github/workflows/release.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -87,43 +87,31 @@ jobs:
8787
# include:
8888
# - name: build-24
8989
# runner: ubuntu-latest
90-
# node_arch: x64
9190
# target_arch: ""
9291
# run_tests: true
9392
# run_electron_tests: false
9493
# - name: build-electron-41
9594
# runner: ubuntu-latest
96-
# node_arch: x64
9795
# target_arch: ""
9896
# run_tests: false
9997
# run_electron_tests: true
10098
# - name: build-macos-24
10199
# runner: macos-13
102-
# node_arch: x64
103100
# target_arch: ""
104101
# run_tests: true
105102
# run_electron_tests: false
106103
# - name: build-macos-24-arm64
107104
# runner: macos-13
108-
# node_arch: x64
109105
# target_arch: arm64
110106
# run_tests: false
111107
# run_electron_tests: false
112-
# - name: windows-24_x86
113-
# runner: windows-latest
114-
# node_arch: x86
115-
# target_arch: ""
116-
# run_tests: true
117-
# run_electron_tests: true
118108
# - name: windows-24_x64
119109
# runner: windows-latest
120-
# node_arch: x64
121110
# target_arch: ""
122111
# run_tests: true
123112
# run_electron_tests: true
124113
# - name: windows-24_arm64
125114
# runner: windows-latest
126-
# node_arch: x64
127115
# target_arch: arm64
128116
# run_tests: false
129117
# run_electron_tests: false
@@ -144,7 +132,6 @@ jobs:
144132
# uses: actions/setup-node@v6
145133
# with:
146134
# node-version-file: .nvmrc
147-
# architecture: ${{ matrix.node_arch }}
148135
# cache: pnpm
149136
#
150137
# - name: Install Linux build dependencies

.github/workflows/test.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -124,16 +124,10 @@ jobs:
124124
fail-fast: false
125125
matrix:
126126
include:
127-
- name: windows-24_x86
128-
node_arch: x86
129-
target_arch: ""
130-
run_tests: true
131127
- name: windows-24_x64
132-
node_arch: x64
133128
target_arch: ""
134129
run_tests: true
135130
- name: windows-24_arm64
136-
node_arch: x64
137131
target_arch: arm64
138132
run_tests: false
139133
steps:
@@ -146,8 +140,6 @@ jobs:
146140

147141
- name: Setup Project
148142
uses: ./.github/actions/setup-node-pnpm
149-
with:
150-
node-architecture: ${{ matrix.node_arch }}
151143

152144
- name: Build
153145
env:

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
24.14.0
1+
24

0 commit comments

Comments
 (0)