Fix cursor visibility issue in code blocks on iOS/iPadOS#317
Fix cursor visibility issue in code blocks on iOS/iPadOS#317jparkerweb wants to merge 5 commits into
Conversation
jparkerweb
commented
Mar 8, 2026
- Added z-index rules for CodeMirror cursor elements
- Removed isolation:isolate on iOS devices to prevent rendering issues
- Added hardware acceleration for better performance
- Fixes 🐛 Cursor is invisible on iPadOS 26 DB3 with only this plugin and dataview #285: cursor disappearing in code blocks when banner is present
- Added z-index rules for CodeMirror cursor elements - Removed isolation:isolate on iOS devices to prevent rendering issues - Added hardware acceleration for better performance - Fixes #285: cursor disappearing in code blocks when banner is present 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical rendering issue on iOS/iPadOS where the CodeMirror cursor would become invisible within code blocks, particularly when a banner element was active. The changes involve strategic adjustments to CSS properties, including Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix a cursor visibility issue on iOS/iPadOS within code blocks when a banner is present. The changes involve adding several CSS rules to manage stacking contexts (z-index), force hardware acceleration for better rendering, and override the isolation property specifically for iOS. While the approach is generally sound and targets the right areas, I've found a couple of opportunities for improvement. One of the new rules could lead to performance and positioning issues due to its broad application. Another rule's comment is inconsistent with its placement, potentially causing confusion. My review includes specific suggestions to refine these rules for better correctness, performance, and maintainability.
…-index:0 - Replace isolation:isolate with z-index:0 to avoid WebKit compositing bug (Bug 94985) - Add caret-color workaround scoped to .is-ios for Safari caret rendering - Remove broad z-index/position overrides on .cm-line that broke themes - Remove unnecessary GPU layer promotion (translateZ) and iOS @supports block