Handle exceptions during receive and dispose timer#24
Open
Nuklon wants to merge 3 commits into
Open
Conversation
Owner
|
Hi, I agree the OperationCanceledException should be handled of course (I've been working on asyncifying TFTPServer and ran into the same issue). But there's a good reason to have just one thread/maintask: this ensures I don't need locking for state updates of the dhcp server. I'll have a go at merging the fixes I applied to TFTPServer into DHCPServer, that should do the trick. |
Address feedback.
Author
|
Ah, yes, I see. The problem is that with WhenAny one task remains running in the background and never catched properly. I think it makes sense to add some trivial synchronization here, I've added another commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceptions weren't handled properly, causing them to appear in UnobservedTaskException.
Also the Timer created during MainTask wasn't disposed. I've split this up in two methods to greatly simplify the logic.