Add Support for Multifile Distribution Downloads#167
Merged
Conversation
11f49da to
5c34813
Compare
5c34813 to
97748ce
Compare
Update method signature for distribution files to match existing methods Skip checksum validation for multifile downloads where no checksum is provided
…as distribution name)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for downloading multiple files from a single distribution. Previously, the SDK assumed each distribution contained exactly one file. This update enables distributions to contain multiple files and provides methods to list, filter, and download them individually or in bulk.
What's Changed
New Features
1. List Distribution Files
A new method to discover all files available in a distribution:
2. Selective File Downloads
Download specific files from a distribution instead of all files:
3. Multifile Streaming
Stream multiple files with individual InputStream access:
5. Checksum Validation changes for Glue Delivery
For datasets delivered via AWS Glue (currently the only delivery channel supporting multifile distributions), checksum validation is automatically skipped when checksums are not provided by the API. This prevents download failures for Glue-delivered multifile distributions where checksums may not be available.
The SDK now:
gluedelivery channelBreaking Changes
1.
downloadStream()Return Type ChangedBefore:
After:
Impact: All existing code using
downloadStream()must be updated to handle theMap<String, InputStream>return type.2.
download()File Naming ChangedBefore:
{catalog}_{dataset}_{series}.{distribution}common_API_TEST_20230308.csvAfter:
{downloadPath}/{filename}downloads/file1.csv,downloads/file2.csvImpact: Any code relying on the previous file naming convention needs to be updated to handle the new naming scheme. In the future we should return a File object to that specific file when downloading.