fix: resolve #721 — Fix: Search crashes due to recent Spotify API changes (null items, missing tracks/publisher)#729
Open
chinhkrb113 wants to merge 2 commits into
Conversation
… API changes (null items, missing tracks/publisher) Fixes jpochyla#721 Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
… API changes (null items, missing tracks/publisher) Fixes jpochyla#721 Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combined multi-file contribution:
Changes
psst-gui/src/data/utils.rspsst-gui/src/data/playlist.rsWhy
psst-gui/src/data/utils.rs: Spotify's API now occasionally returnsnullentries in theitemsarray of paginated responses (e.g., region-blocked tracks). The current deserialization expects every element to be a valid struct, causing a crash like "invalid type: null, expected struct Playlist". We need a custom deserializer that filters out null values from the items array.