Skip to content

fix: resolve #721 — Fix: Search crashes due to recent Spotify API changes (null items, missing tracks/publisher) #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chinhkrb113 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: resolve #721 — Fix: Search crashes due to recent Spotify API changes (null items, missing tracks/publisher) #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2821216
fix: resolve #721 — Fix: Search crashes due to recent Spotify API cha…
chinhkrb113 May 12, 2026
5018ac0
fix: resolve #721 — Fix: Search crashes due to recent Spotify API cha…
chinhkrb113 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion psst-gui/src/data/playlist.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ where
total: Option<usize>,
}

Ok(PlaylistTracksRef::deserialize(deserializer)?.total)
Ok(Option::<PlaylistTracksRef>::deserialize(deserializer)?.and_then(|r| r.total))
}

fn deserialize_description<'de, D>(deserializer: D) -> Result<Arc<str>, D::Error>
Expand Down
11 changes: 11 additions & 0 deletions psst-gui/src/data/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ impl<T: Data> Cached<T> {

#[derive(Deserialize)]
pub struct Page<T: Clone> {
#[serde(deserialize_with = "deserialize_ignore_nulls")]
pub items: Vector<T>,
pub limit: usize,
pub offset: usize,
Expand Down Expand Up @@ -158,6 +159,16 @@ where
Ok(Option::deserialize(deserializer)?.map(|Wrapper(val)| val))
}

pub fn deserialize_ignore_nulls<'de, D, T>(deserializer: D) -> Result<Vector<T>, D::Error>
where
T: Clone,
T: Deserialize<'de>,
D: Deserializer<'de>,
{
let items: Vec<Option<T>> = Vec::deserialize(deserializer)?;
Ok(items.into_iter().flatten().collect())
}

pub fn deserialize_first_page<'de, D, T>(deserializer: D) -> Result<Vector<T>, D::Error>
where
T: Clone,
Expand Down