Security: OAuth callback HTTP request line is read without length limit#732
Open
kumburovicbranko682-boop wants to merge 1 commit into
Conversation
…h limit The `handle_callback_connection` function uses `reader.read_line(&mut request_line)` with no bound on the size of the line an attacker can send. A malicious process on localhost can open a TCP connection to 127.0.0.1:8888 and stream gigabytes of data without a newline, causing unbounded memory allocation until the process is OOM-killed. While the listener only runs during the OAuth sign-in window, any local process or script can exploit this. Affected files: oauth.rs Signed-off-by: kumburovicbranko682-boop <295886834+kumburovicbranko682-boop@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
handle_callback_connectionfunction usesreader.read_line(&mut request_line)with no bound on the size of the line an attacker can send. A malicious process on localhost can open a TCP connection to 127.0.0.1:8888 and stream gigabytes of data without a newline, causing unbounded memory allocation until the process is OOM-killed. While the listener only runs during the OAuth sign-in window, any local process or script can exploit this.Severity:
mediumFile:
psst-core/src/oauth.rsSolution
Read with a size limit using
BufRead::read_linereplacement or a manual loop with a cap. For example, limit to 8 KiB:Changes
psst-core/src/oauth.rs(modified)Testing