make it work for react 18#1392
Open
collinschaafsma wants to merge 2 commits into
Open
Conversation
nairvishal
approved these changes
Oct 23, 2023
|
Are there plans to merge this ? I'm also having issues getting modals to work with react 18 |
|
@collinschaafsma how did you build the app? |
|
@jpuri @nairvishal are there plans to merge this one? also facing this problem with modals and react 18 |
|
I have the same problem. Is there any way to merge this? @collinschaafsma @nairvishal @jpuri |
|
@jpuri +1 for this here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makes it work for react 18, tested in next 13 using app dir, probably a cleaner way, but this will work