[Issue-1429] Resolve Bug for Mention Suggestion Clicks Overwriting Text#1440
Open
nickbely-novata wants to merge 1 commit into
Open
[Issue-1429] Resolve Bug for Mention Suggestion Clicks Overwriting Text#1440nickbely-novata wants to merge 1 commit into
nickbely-novata wants to merge 1 commit into
Conversation
|
Also encounter this issue. It works in case you use keyboard to select a person and then press enter key. But it doesn't when you use mouse... This request should be merged |
|
@jpuri is this possible to merge this? |
|
@jpuri it would be great if it can be merged asap. Also encounered this issue |
Author
|
I wouldn't count on it, the repo owner hasn't merged anything in over a year. Your best bets are to fork it with the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved the following issue: #1429.
Root Cause: Clicks on the suggestion dropdown menu forcibly change the
anchorOffsetandfocusOffsetposition of the cursor.Resolved by:
mentionIndexprior to the click taking place, and passing it into theaddMentionfunction.This was the optimal quick solution for now since stopping click event propagation or preventing default click behavior did not prevent the cursor position from updating.
Any expediency with reviewing and merging this bug fix would be appreciated, @jpuri.