fix: missing return value for css method#1282
Closed
ajiho wants to merge 1 commit intojquery:mainfrom
ajiho:fix-css-return
Closed
fix: missing return value for css method#1282ajiho wants to merge 1 commit intojquery:mainfrom ajiho:fix-css-return
ajiho wants to merge 1 commit intojquery:mainfrom
ajiho:fix-css-return
Conversation
Signed-off-by: ajiho <lujiahao@88.com>
The committers listed above are authorized under a signed CLA. |
mgol
reviewed
Aug 12, 2025
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
Thanks for the PR. I wonder if that's not going to be too confusing, maybe separating these signatures would be clearer.
If we had another similar API to compare, that'd help with alignment. .val() also has multiple return types but for a getter with no parameters so it makes sense. I'm worried here people may erroneously interpret this change as .css( propertyName ) possibly returning an array as well.
Member
|
When separating, the second example would have to be moved to the signature |
mgol
requested changes
Sep 3, 2025
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
Marking as "Request changes" until my remarks are addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1281
I changed my mind, actually there's no need to create a new entry, just add multiple possible return scenarios
ref: val.xml#L5