Core: use correct module format for r.js optimization#1830
Open
blacktail wants to merge 1 commit intojquery:mainfrom
Open
Core: use correct module format for r.js optimization#1830blacktail wants to merge 1 commit intojquery:mainfrom
blacktail wants to merge 1 commit intojquery:mainfrom
Conversation
|
|
blacktail
force-pushed
the
master
branch
4 times, most recently
from
780a057 to
26414d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if there is no real function definition in the AMD define, r.js won't generate an entry for the core.js in the generated bundle, which will make errors if some project use r.js to bundle.