Skip to content

Upgrade: add 4.0 upgrade guide#250

Merged
timmywil merged 6 commits intojquery:mainfrom
timmywil:upgrade
May 12, 2025
Merged

Upgrade: add 4.0 upgrade guide#250
timmywil merged 6 commits intojquery:mainfrom
timmywil:upgrade

Conversation

@timmywil
Copy link
Copy Markdown
Member

@timmywil timmywil commented Mar 31, 2025

  • Also update node dependencies (I did this so I could test locally)

Fixes jquery/jquery#5365

@timmywil timmywil requested review from gibson042 and mgol March 31, 2025 15:14
Copy link
Copy Markdown
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good first draft! I added some comments.

Comment thread pages/upgrade-guide/4.0.md Outdated
Comment thread pages/upgrade-guide/4.0.md
Comment thread pages/upgrade-guide/4.0.md Outdated
Comment thread pages/upgrade-guide/4.0.md
Comment thread pages/upgrade-guide/4.0.md Outdated
Comment thread pages/upgrade-guide/4.0.md Outdated
Comment thread pages/upgrade-guide/4.0.md
Comment thread pages/upgrade-guide/4.0.md
Comment thread pages/upgrade-guide/4.0.md
Comment thread pages/upgrade-guide/4.0.md
@timmywil timmywil requested a review from mgol April 28, 2025 15:06
Copy link
Copy Markdown
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more comments. Thanks!

Comment thread pages/upgrade-guide/4.0.md Outdated
Comment thread pages/upgrade-guide/4.0.md Outdated
Comment thread pages/upgrade-guide/4.0.md Outdated
Comment thread pages/upgrade-guide/4.0.md Outdated
Comment thread pages/upgrade-guide/4.0.md
Comment thread pages/upgrade-guide/4.0.md Outdated
Comment thread pages/upgrade-guide/4.0.md
Comment thread pages/upgrade-guide/4.0.md Outdated
Comment thread pages/upgrade-guide/4.0.md
Comment thread pages/upgrade-guide/4.0.md
@timmywil timmywil requested a review from mgol May 5, 2025 15:46
Copy link
Copy Markdown
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, but LGTM otherwise. Good work!

Comment thread pages/upgrade-guide/4.0.md Outdated
This has been renamed since 3.7.0 to jQuery.Deferred.getErrorHook. It is used to pass the original error to jQuery.Deferred.exceptionHook. Previously, we recommended passing the stack but that didn't play well with source maps.
This has been renamed since 3.7.0 to `jQuery.Deferred.getErrorHook`. It is used to pass the original error to `jQuery.Deferred.exceptionHook`. Previously, we recommended passing the stack but that didn't play well with source maps. `jQuery.Deferred.exceptionHook` can be used to debug asynchronous errors.

TODO: link to documentation
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timmywil timmywil merged commit 18dd487 into jquery:main May 12, 2025
1 check passed
@timmywil timmywil deleted the upgrade branch May 12, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Prepare a 4.0 upgrade guide

2 participants