Skip to content

Commit add8620

Browse files
committed
[fix] raise PKeyError upon invalid RSA key
1 parent 1dbb89e commit add8620

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/main/java/org/jruby/ext/openssl/PKeyRSA.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ public IRubyObject initialize(final ThreadContext context, final IRubyObject[] a
336336
if ( key == null ) key = tryPKCS8EncodedKey(runtime, rsaFactory, str.getBytes());
337337
if ( key == null ) key = tryX509EncodedKey(runtime, rsaFactory, str.getBytes());
338338

339-
if ( key == null ) throw newRSAError(runtime, "Neither PUB key nor PRIV key:");
339+
if ( key == null ) throw newPKeyError(runtime, "Neither PUB key nor PRIV key:");
340340

341341
if ( key instanceof KeyPair ) {
342342
PublicKey publicKey = ((KeyPair) key).getPublic();

src/test/ruby/rsa/test_rsa.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ def test_RSAPrivateKey_encrypted
437437
cipher = OpenSSL::Cipher.new("aes-128-cbc")
438438
exported = rsa1024.to_pem(cipher, "abcdef\0\1")
439439
assert_same_rsa rsa1024, OpenSSL::PKey::RSA.new(exported, "abcdef\0\1")
440-
assert_raise(OpenSSL::PKey::RSAError) {
440+
assert_raise(OpenSSL::PKey::PKeyError) {
441441
OpenSSL::PKey::RSA.new(exported, "abcdef")
442442
}
443443
end

src/test/ruby/test_pkey.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def test_pkey_pem_file_error
7878
begin
7979
ret = OpenSSL::PKey::RSA.new('not a PEM file')
8080
fail "expected OpenSSL::PKey::RSA.new to raise (got: #{ret.inspect})"
81-
rescue OpenSSL::PKey::RSAError
81+
rescue OpenSSL::PKey::PKeyError
8282
assert true
8383
end
8484
end

0 commit comments

Comments
 (0)