[build] upgrade JUnit 4 to JUnit 5 (Jupiter)

Replace junit:junit 4.13.1 with org.junit.jupiter:junit-jupiter 5.11
and add maven-surefire-plugin 3.5.2 for JUnit Platform test discovery

Author: kares

Mavenfile

@@ -85,7 +85,9 @@ end
 jar 'org.jruby:jruby-core', '9.2.0.0', :scope => :provided
 # for invoker generated classes we need to add javax.annotation when on Java > 8
 jar 'javax.annotation:javax.annotation-api', '1.3.1', :scope => :compile
-jar 'junit:junit', '[4.13.1,)', :scope => :test
+jar 'org.junit.jupiter:junit-jupiter', '5.11.4', :scope => :test
+
+plugin :surefire, '3.5.2'
 
 # NOTE: to build on Java 11 - installing gems fails (due old jossl) with:
 #  load error: jopenssl/load -- java.lang.StringIndexOutOfBoundsException

pom.xml

@@ -108,9 +108,9 @@ DO NOT MODIFY - GENERATED CODE
       <scope>compile</scope>
     </dependency>
     <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-      <version>[4.13.1,)</version>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter</artifactId>
+      <version>5.11.4</version>
       <scope>test</scope>
     </dependency>
   </dependencies>
@@ -320,6 +320,10 @@ DO NOT MODIFY - GENERATED CODE
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <version>3.5.2</version>
+      </plugin>
       <plugin>
         <artifactId>maven-deploy-plugin</artifactId>
         <version>2.8.1</version>

src/test/java/org/jruby/ext/openssl/CipherTest.java

@@ -1,7 +1,7 @@
 package org.jruby.ext.openssl;
 
-import org.junit.*;
-import static org.junit.Assert.*;
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.*;
 
 /**
  * @author kares

src/test/java/org/jruby/ext/openssl/SecurityHelperTest.java

@@ -1,11 +1,11 @@
 
 package org.jruby.ext.openssl;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertSame;
-import static org.junit.Assert.fail;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.junit.jupiter.api.Assertions.fail;
 
 import java.security.KeyStoreException;
 import java.security.NoSuchAlgorithmException;
@@ -15,9 +15,9 @@
 import java.security.cert.CertificateException;
 import java.security.cert.CertificateFactory;
 
-import org.junit.After;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
 /**
  * @author kares
@@ -31,12 +31,12 @@ public static void setBouncyCastleProvider() {
 
     private Provider savedProvider;
 
-    @Before
+    @BeforeEach
     public void saveSecurityProvider() {
         savedProvider = SecurityHelper.getSecurityProvider();
     }
 
-    @After
+    @AfterEach
     public void restoreSecurityProvider() {
         SecurityHelper.securityProvider = savedProvider;
     }

src/test/java/org/jruby/ext/openssl/VersionTest.java

@@ -24,19 +24,19 @@
 
 package org.jruby.ext.openssl;
 
-import org.junit.Test;
-import org.junit.After;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.AfterEach;
 
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import static org.jruby.ext.openssl.OpenSSL.*;
 
 public class VersionTest {
 
     private final String javaVersion = System.getProperty("java.version");
 
-    @After
+    @AfterEach
     public void restoreJavaVersion() {
         System.setProperty("java.version", javaVersion);
     }