[fix] DH#params returned pub_key and priv_key swapped

kares · kares · commit cefa88760206 · 2026-03-30T19:55:33.000+02:00
diff --git a/src/main/java/org/jruby/ext/openssl/PKeyDH.java b/src/main/java/org/jruby/ext/openssl/PKeyDH.java
@@ -347,8 +347,8 @@ public IRubyObject params() {
 
         params.put(runtime.newString("p"), BN.newBN(runtime, p));
         params.put(runtime.newString("g"), BN.newBN(runtime, g));
-        params.put(runtime.newString("pub_key"), BN.newBN(runtime, x));
-        params.put(runtime.newString("priv_key"), BN.newBN(runtime, y));
+        params.put(runtime.newString("pub_key"), BN.newBN(runtime, y));
+        params.put(runtime.newString("priv_key"), BN.newBN(runtime, x));
 
         return RubyHash.newHash(runtime, params, runtime.getNil());
     }

Original file line number	Diff line number	Diff line change
`@@ -347,8 +347,8 @@ public IRubyObject params() {`
`347`	`347`
`348`	`348`	`params.put(runtime.newString("p"), BN.newBN(runtime, p));`
`349`	`349`	`params.put(runtime.newString("g"), BN.newBN(runtime, g));`
`350`		`- params.put(runtime.newString("pub_key"), BN.newBN(runtime, x));`
`351`		`- params.put(runtime.newString("priv_key"), BN.newBN(runtime, y));`
	`350`	`+ params.put(runtime.newString("pub_key"), BN.newBN(runtime, y));`
	`351`	`+ params.put(runtime.newString("priv_key"), BN.newBN(runtime, x));`
`352`	`352`
`353`	`353`	`return RubyHash.newHash(runtime, params, runtime.getNil());`
`354`	`354`	`}`