Partially make forwarding across evals work. This fixed * and ** but ... is done differently so not in this commit

Author: enebo

src/main/java/org/jruby/prism/builder/IRBuilderPrism.java

@@ -704,7 +704,12 @@ protected Operand[] buildCallArgsArray(Node[] children, int[] flags) {
                     flags[0] |= CALL_SPLATS;
                     builtArgs[i] = new Splat(addResultInstr(new BuildSplatInstr(temp(), build(splat), true)));
                 } else {
-                    builtArgs[i] = new Splat(scope.lookupExistingLVar(symbol("*")));
+                    // Note: WOOF.  Prism forwarding returns '*' as an expressless splat instead of a splat
+                    // of a lvar named '*'.  IRScope cannot give us the power to search assuming this is all
+                    // going to be handed to it by the parser so we need to look it up in StaticScope.
+                    var slot = scope.getStaticScope().isDefined("*");
+                    var lvar = new LocalVariable(symbol("*"), slot >> 16, slot & 0xffff, true);
+                    builtArgs[i] = new Splat(lvar);
                 }
             } else if (child instanceof KeywordHashNode hash && i == numberOfArgs - 1) {
                 builtArgs[i] = buildCallKeywordArguments(hash, flags); // FIXME: here and possibly AST make isKeywordsHash() method.
@@ -1885,8 +1890,12 @@ private Operand buildRestKeywordArgs(KeywordHashNode keywordArgs, int[] flags) {
             var pair = (AssocSplatNode) pairs[0];
 
             if (pair.value == null) {
-                return scope.lookupExistingLVar(symbol("**"));
-            } else {
+                // Note: WOOF.  Prism forwarding returns '**' as an expressless splat instead of a splat
+                // of a lvar named '**'.  IRScope cannot give us the power to search assuming this is all
+                // going to be handed to it by the parser so we need to look it up in StaticScope.
+                var slot = scope.getStaticScope().isDefined("**");
+                return new LocalVariable(symbol("**"), slot >> 16, slot & 0xffff, true);
+             } else {
                 Operand splat = buildWithOrder(pair.value, containsVariableAssignment);
 
                 return addResultInstr(new RuntimeHelperCall(temp(), HASH_CHECK, new Operand[]{splat}));

src/main/java/org/jruby/prism/parser/ParserPrismBase.java

@@ -7,7 +7,6 @@
 import org.jruby.RubyArray;
 import org.jruby.RubyFile;
 import org.jruby.RubyInstanceConfig;
-import org.jruby.RubySymbol;
 import org.jruby.ext.coverage.CoverageData;
 import org.jruby.management.ParserStats;
 import org.jruby.parser.Parser;
@@ -199,14 +198,25 @@ private void evalScopesRecursive(StaticScope scope, ArrayList<ParsingOptions.Sco
             evalScopesRecursive(scope.getEnclosingScope(), scopes);
         }
 
+        var variables = scope.getVariables();
+
         scopes.add(new ParsingOptions.Scope(
                 Arrays
-                        .stream(scope.getVariables())
+                        .stream(variables)
                         .map(String::getBytes)
                         .toArray(byte[][]::new),
                 IntStream
                         .range(0, scope.getVariables().length)
-                        .mapToObj((i) -> ParsingOptions.Forwarding.NONE)
+                        .mapToObj((i) -> {
+                            var name = variables[i];
+                            return switch (name) {
+                                case "..." -> ParsingOptions.Forwarding.ALL;
+                                case "*" -> ParsingOptions.Forwarding.POSITIONAL;
+                                case "**" -> ParsingOptions.Forwarding.KEYWORD;
+                                case "&" -> ParsingOptions.Forwarding.BLOCK;
+                                default -> ParsingOptions.Forwarding.NONE;
+                            };
+                        })
                         .toArray(ParsingOptions.Forwarding[]::new)));
     }