Merge pull request #18 from rkoretskiy-cloudlinux/fix/quote-credentials-in-replaceFirst

headius · web-flow · commit 9e862f1cd36c · 2026-03-27T13:49:55.000-07:00
Fix IllegalArgumentException when credentials contain $ or \
diff --git a/mavengem-wagon/src/main/java/org/torquebox/mojo/mavengem/wagon/MavenGemWagon.java b/mavengem-wagon/src/main/java/org/torquebox/mojo/mavengem/wagon/MavenGemWagon.java
@@ -24,6 +24,7 @@
 import java.net.SocketAddress;
 import java.net.URL;
 import java.net.URLConnection;
+import java.util.regex.Matcher;
 
 public class MavenGemWagon extends StreamWagon {
 
@@ -115,7 +116,7 @@ private URL withAuthentication(String url)
             throws MalformedURLException {
         if (authenticationInfo != null && authenticationInfo.getUserName() != null) {
             String credentials = authenticationInfo.getUserName() + ":" + authenticationInfo.getPassword();
-            url = url.replaceFirst("^(https?://)(.*)$", "$1" + credentials + "@$2");
+            url = url.replaceFirst("^(https?://)(.*)$", "$1" + Matcher.quoteReplacement(credentials) + "@$2");
         }
         return new URL(url);
     }

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@`
`24`	`24`	`import java.net.SocketAddress;`
`25`	`25`	`import java.net.URL;`
`26`	`26`	`import java.net.URLConnection;`
	`27`	`+import java.util.regex.Matcher;`
`27`	`28`
`28`	`29`	`public class MavenGemWagon extends StreamWagon {`
`29`	`30`
`@@ -115,7 +116,7 @@ private URL withAuthentication(String url)`
`115`	`116`	`throws MalformedURLException {`
`116`	`117`	`if (authenticationInfo != null && authenticationInfo.getUserName() != null) {`
`117`	`118`	`String credentials = authenticationInfo.getUserName() + ":" + authenticationInfo.getPassword();`
`118`		`- url = url.replaceFirst("^(https?://)(.*)$", "$1" + credentials + "@$2");`
	`119`	`+ url = url.replaceFirst("^(https?://)(.*)$", "$1" + Matcher.quoteReplacement(credentials) + "@$2");`
`119`	`120`	`}`
`120`	`121`	`return new URL(url);`
`121`	`122`	`}`