Skip to content

Commit 7615427

Browse files
committed
Remove the versioned jar from repo
This was probably added to allow running warbler directly from the repository, but versioning the jar will bloat up the size of the repository with every commit, and it will usually be behind the actual source version. Removing here and we'll deal with fallout later. Supporting changes: * spec and integration targets should build jar first. * jar must be included explicitly in gem since it is no longer versioned. * clean should wipe out the jar.
1 parent e697a3f commit 7615427

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

Rakefile

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,15 @@ require 'bundler/gem_helper'
1010
Bundler::GemHelper.install_tasks :dir => File.dirname(__FILE__)
1111

1212
require 'rake/clean'
13-
CLEAN << "pkg" << "doc" << Dir['integration/**/target']
13+
CLEAN << "pkg" << "doc" << Dir['integration/**/target'] << "lib/warbler_jar.jar"
1414

1515
require 'rspec/core/rake_task'
1616
RSpec::Core::RakeTask.new(:spec) do |t|
1717
t.rspec_opts = ['--color', "--format documentation"]
1818
end
1919

20+
task :spec => :jar
21+
2022
task :default => :spec
2123

2224
# use Mavenfile to define :jar task
@@ -36,7 +38,7 @@ task :jar do
3638
end
3739

3840
desc 'run some integration test'
39-
task :integration do
41+
task :integration => :jar do
4042
success = mvn.verify
4143
exit(1) unless success
4244
end

lib/warbler_jar.jar

-20.3 KB
Binary file not shown.

warbler.gemspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ bundle up all of your application files for deployment to a Java environment.}
2020
reject { |file| file =~ /^spec|test\// }. # spec/**/*.spec
2121
reject { |file| file =~ /^integration\// }. # (un-used) *.rake files
2222
reject { |file| file =~ /^rakelib\// } # (un-used) *.rake files
23+
gem.files << "lib/warbler_jar.jar"
24+
2325
gem.test_files = [] # tests and specs add 700k to the gem, so don't include them
2426
gem.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
2527
gem.require_paths = ["lib"]

0 commit comments

Comments
 (0)