fix(modeling): various fixes, style changes, and small enhancements

* feat(modeling): allow appendArc, appendBezier, appendPoints to closed paths

* fix(modeling): corrected snap of path2 and path3 when closed

* docs(modeling): changes from reviews

* fix(modeling): small fix to parameter checks

* perf(modeling): small performace changes

* fix(modeling): corrected close, reverse, and transform functions in geometries

* perf(modeling): changed extrudeLinearGeom2 to use preallocated mat4 and vec3

* build(all): changed linting to use eslint directly

* style(all): changes based on lint

* style(all): small fixes for consistent return values

* style(all): changes for consistent default case statements

* style(all): changes for consistent assignment statements

* style(all): changes for consistent blocks

* fix(modeling): corrected retessellateCoplanarPolygons to ignore pourly constructed polygons

* fix(modeling): stronger validation of polygons in geom3 objects

* test(modeling): small adjustments to tests due to changes

Author: z3dev

packages/modeling/src/geometries/geom3/validate.js

@@ -22,7 +22,17 @@ export const validate = (object) => {
   }
 
   // check polygons
-  object.polygons.forEach(poly3.validate)
+  object.polygons.forEach((p, i) => {
+    if (p.vertices.length < 3) {
+      throw new Error(`invalid polygon ${i}: only ${p.vertices.length} vertices`)
+    }
+
+    try {
+      poly3.validate(p)
+    } catch (e) {
+      throw new Error(`invalid polygon ${i}: ${e}`)
+    }
+  })
   validateManifold(object)
 
   // check transforms

packages/modeling/src/operations/modifiers/reTesselateCoplanarPolygons.js

@@ -317,8 +317,8 @@ export const reTesselateCoplanarPolygons = (sourcePolygons) => {
           const vertices3d = points2d.map((point2d) => orthonormalFormula.to3D(point2d))
           const polygon = poly3.fromVerticesAndPlane(vertices3d, plane) // TODO support shared
 
-          // if we let empty polygon out, next retesselate will crash
-          if (polygon.vertices.length) destPolygons.push(polygon)
+          // if we let invalid polygons out, next retesselate will crash
+          if (polygon.vertices.length > 2) destPolygons.push(polygon)
         }
       }
     } // if(yIndex > 0)

packages/modeling/src/operations/modifiers/reTesselateCoplanarPolygons.test.js

@@ -66,7 +66,9 @@ test('retessellateCoplanarPolygons: should merge coplanar polygons', (t) => {
   polyL = translatePoly3([-15, -15, -15], polyE)
 
   obs = reTesselateCoplanarPolygons([polyH, polyI, polyJ, polyK, polyL])
-  t.is(obs.length, 1)
+  obs.forEach((polygon) => {
+    poly3.validate(polygon)
+  })
 })
 
 // Test for mark-and-filter optimization: multiple polygons that reach their
@@ -85,9 +87,8 @@ test('retessellateCoplanarPolygons: should correctly handle multiple polygon rem
   // Each triangle should be preserved (they don't overlap)
   t.is(obs.length, 3)
 
-  // Verify each polygon has 3 vertices (triangles)
   obs.forEach((polygon) => {
-    t.is(polygon.vertices.length, 3)
+    poly3.validate(polygon)
   })
 })
 
@@ -103,3 +104,28 @@ test('retessellateCoplanarPolygons: should merge adjacent polygons with shared e
   t.is(obs.length, 1)
   t.is(obs[0].vertices.length, 4) // rectangle has 4 vertices
 })
+
+test('retessellateCoplanarPolygons: should not return invalid polygons', (t) => {
+  const polyA = poly3.create([
+    [ 3.72172376113686, -3.7661089598376325, 13 ],
+    [ 3.72172376113686, -3.7661089598376325, 13.515937566757202 ],
+    [ 3.721663581864801, -3.766195461144145, 13.515937566757202 ]
+  ])
+  const polyB = poly3.create([
+    [ 3.721663581864801, -3.766195461144145, 13.0084828728813 ],
+    [ 3.721663581864801, -3.766195461144145, 13.00100040435791 ],
+    [ 3.721716664059388, -3.7661191611320772, 13.00100040435791 ]
+  ])
+  const polyC = poly3.create([
+    [ 3.721663581864801, -3.766195461144145, 13.515937566757202 ],
+    [ 3.721663581864801, -3.766195461144145, 13.0084828728813 ],
+    [ 3.7217166640593886, -3.766119161132077, 13.00100040435791 ],
+    [ 3.7217236444490864, -3.766109127563903, 13.00100040435791 ]
+  ])
+  const obs = reTesselateCoplanarPolygons([polyA, polyB, polyC])
+  t.is(obs.length, 1)
+
+  obs.forEach((polygon) => {
+    poly3.validate(polygon)
+  })
+})

packages/modeling/src/operations/modifiers/retessellate.js

@@ -18,6 +18,7 @@ export const retessellate = (geometry) => {
     return geometry
   }
 
+  // FIXME this is creating new polygons
   const polygons = geom3.toPolygons(geometry).map((polygon, index) => ({ vertices: polygon.vertices, plane: poly3.plane(polygon), index: index }))
   const classified = classifyPolygons(polygons)
 

packages/modeling/src/operations/offsets/offsetGeom3.test.js

@@ -91,6 +91,6 @@ test('offsetGeom3: offset completes properly, issue 876', (t) => {
 
   const obs = offset({ delta: 1.3, corners: 'round', segments: 12 }, sub)
   t.notThrows.skip(() => geom3.validate(obs))
-  t.is(measureArea(obs), 524.9674760547548)
-  t.is(measureVolume(obs), 604.0599465573156)
+  t.is(measureArea(obs), 524.9674756919702)
+  t.is(measureVolume(obs), 604.0599468042326)
 })