perf(modeling): more perf changes to plane

Author: z3dev

packages/modeling/src/maths/plane/fromNormalAndPoint.js

@@ -18,12 +18,10 @@ import * as vec3 from '../vec3/index.js'
  * @alias module:modeling/maths/plane.fromNormalAndPoint
  */
 export const fromNormalAndPoint = (out, normal, point) => {
-  const u = vec3.normalize(out, normal)
-  const w = vec3.dot(point, u)
+  // normalize to out
+  vec3.normalize(out, normal)
+  // calculate distance
+  out[3] = vec3.dot(point, out)
 
-  out[0] = u[0]
-  out[1] = u[1]
-  out[2] = u[2]
-  out[3] = w
   return out
 }

packages/modeling/src/maths/plane/fromPoints.js

@@ -1,10 +1,13 @@
 import * as vec3 from '../vec3/index.js'
 
+const ba = vec3.create()
+const ca = vec3.create()
+
 /**
  * Create a plane from the given points.
  *
  * @param {Plane} out - receiving plane
- * @param {Array} vertices - points on the plane
+ * @param {Array} vertices - list of points on the plane
  * @returns {Plane} out
  * @alias module:modeling/maths/plane.fromPoints
  */
@@ -13,8 +16,6 @@ export const fromPoints = (out, ...vertices) => {
 
   // Calculate normal vector for a single vertex
   // Inline to avoid allocations
-  const ba = vec3.create()
-  const ca = vec3.create()
   const vertexNormal = (index) => {
     const a = vertices[index]
     const b = vertices[(index + 1) % len]
@@ -37,7 +38,7 @@ export const fromPoints = (out, ...vertices) => {
     vertices.forEach((v, i) => {
       vec3.add(out, out, vertexNormal(i))
     })
-    // renormalize normal vector
+    // normalize sum
     vec3.normalize(out, out)
   }
   out[3] = vec3.dot(out, vertices[0])

packages/modeling/src/maths/plane/fromPointsRandom.js

@@ -34,8 +34,7 @@ export const fromPointsRandom = (out, a, b, c) => {
   vec3.normalize(normal, normal)
 
   // and distance
-  const w = vec3.dot(normal, a)
-  out[3] = w
+  out[3] = vec3.dot(normal, a)
 
   return out
 }