Skip to content

fix(modeling): various fixes, style changes, and small enhancements#1463

Merged
mister-jscad merged 16 commits into
V3from
fixes-part-3
Jun 28, 2026
Merged

fix(modeling): various fixes, style changes, and small enhancements#1463
mister-jscad merged 16 commits into
V3from
fixes-part-3

Conversation

@z3dev

@z3dev z3dev commented Jun 27, 2026

Copy link
Copy Markdown
Member

retessellateCoplanarPolygons() was creating invalid poly3 objects with less than two vertices. this is the fix.

FYI, the original code has the same issue, and this bug is present in V2 still.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

z3dev added 16 commits May 30, 2026 15:27
@z3dev
feat(modeling): allow appendArc, appendBezier, appendPoints to closed…
fc0ca2c 
… paths
@z3dev
fix(modeling): corrected snap of path2 and path3 when closed
578466d
@z3dev
docs(modeling): changes from reviews
76132a4
@z3dev
fix(modeling): small fix to parameter checks
b26cf6e
@z3dev
perf(modeling): small performace changes
1104518
@z3dev
fix(modeling): corrected close, reverse, and transform functions in g…
d738828 
…eometries
@z3dev
perf(modeling): changed extrudeLinearGeom2 to use preallocated mat4 a…
c742491 
…nd vec3
@z3dev
build(all): changed linting to use eslint directly
8d70047
@z3dev
style(all): changes based on lint
d277fbf
@z3dev
style(all): small fixes for consistent return values
9028132
@z3dev
style(all): changes for consistent default case statements
8b87c79
@z3dev
style(all): changes for consistent assignment statements
c10ae23
@z3dev
style(all): changes for consistent blocks
0145caa
@z3dev
fix(modeling): corrected retessellateCoplanarPolygons to ignore pourl…
871c3b4 
…y constructed polygons
@z3dev
fix(modeling): stronger validation of polygons in geom3 objects
e9903c2
@z3dev
test(modeling): small adjustments to tests due to changes
a2ee77a
@z3dev z3dev changed the title fix(modeling): aa fix(modeling): corrected retessellateCoplanarPolygons to ignore pourly constructed polygons Jun 27, 2026
@z3dev z3dev changed the title fix(modeling): corrected retessellateCoplanarPolygons to ignore pourly constructed polygons fix(modeling): various fixes, style changes, and small enhancements Jun 27, 2026
mister-jscad
mister-jscad approved these changes Jun 27, 2026
View reviewed changes

@mister-jscad mister-jscad left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mister-jscad
mister-jscad merged commit 2abbb3e into V3 Jun 28, 2026
4 checks passed
@z3dev
z3dev deleted the fixes-part-3 branch July 18, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mister-jscad mister-jscad mister-jscad approved these changes
@platypii platypii Awaiting requested review from platypii
@hrgdavor hrgdavor Awaiting requested review from hrgdavor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@z3dev @mister-jscad