Update CalculateAverageFeeAndDistributorShares to have a test-friendly arity

jshufro · jshufro · commit 4042c8ccbbde · 2024-10-08T19:58:59.000-04:00
diff --git a/shared/services/state/network-state.go b/shared/services/state/network-state.go
@@ -240,7 +240,7 @@ func createNetworkState(batchContracts config.StateManagerContracts, rp *rocketp
 
 	// Calculate avg node fees and distributor shares
 	for _, details := range state.NodeDetails {
-		rpstate.CalculateAverageFeeAndDistributorShares(rp, contracts, details, state.MinipoolDetailsByNode[details.NodeAddress])
+		details.CalculateAverageFeeAndDistributorShares(state.MinipoolDetailsByNode[details.NodeAddress])
 	}
 
 	// Oracle DAO member details
@@ -370,7 +370,7 @@ func createNetworkStateForNode(batchContracts config.StateManagerContracts, rp *
 
 	// Calculate avg node fees and distributor shares
 	for _, details := range state.NodeDetails {
-		rpstate.CalculateAverageFeeAndDistributorShares(rp, contracts, details, state.MinipoolDetailsByNode[details.NodeAddress])
+		details.CalculateAverageFeeAndDistributorShares(state.MinipoolDetailsByNode[details.NodeAddress])
 	}
 
 	// Get the total network effective RPL stake

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ func createNetworkState(batchContracts config.StateManagerContracts, rp *rocketp`
`240`	`240`
`241`	`241`	`// Calculate avg node fees and distributor shares`
`242`	`242`	`for _, details := range state.NodeDetails {`
`243`		`- rpstate.CalculateAverageFeeAndDistributorShares(rp, contracts, details, state.MinipoolDetailsByNode[details.NodeAddress])`
	`243`	`+ details.CalculateAverageFeeAndDistributorShares(state.MinipoolDetailsByNode[details.NodeAddress])`
`244`	`244`	`}`
`245`	`245`
`246`	`246`	`// Oracle DAO member details`
`@@ -370,7 +370,7 @@ func createNetworkStateForNode(batchContracts config.StateManagerContracts, rp *`
`370`	`370`
`371`	`371`	`// Calculate avg node fees and distributor shares`
`372`	`372`	`for _, details := range state.NodeDetails {`
`373`		`- rpstate.CalculateAverageFeeAndDistributorShares(rp, contracts, details, state.MinipoolDetailsByNode[details.NodeAddress])`
	`373`	`+ details.CalculateAverageFeeAndDistributorShares(state.MinipoolDetailsByNode[details.NodeAddress])`
`374`	`374`	`}`
`375`	`375`
`376`	`376`	`// Get the total network effective RPL stake`