Implement review.md recommendations: security fixes, correctness hardening, and CI repair

[Copilot]

Implements all recommendations from review.md and fixes the one pre-existing test failure. Changes are grouped by severity.

Security

• Command injection (src/embedder.js): generateAndSaveProfile was building a shell string with interpolated device and sampleSize values. Replaced execSync(cmd) with execFileSync(process.execPath, [script, '--device', device, ...]).

Correctness

• Overly-broad model matching (src/model-management.js): Both deleteModel and isModelDownloaded used String.includes() in their fallback scan, meaning deleteModel('bert') would match roberta. Replaced with a matchesModelName() helper that requires exact equality or a -// separator prefix.
• Silent pool hang on full degradation (src/worker-pool.js): When the last worker crashed, pending run() promises would never settle. _removeWorker now rejects all queued tasks immediately when the pool empties.
• Dead else branch (src/embedder.js): Provider default ternary's else arm evaluated to options.provider which the ?? had already consumed — simplified to undefined.
• In-place splice mutation (src/embedder.js): applyPerfProfile mutated a const array via splice; changed to let + reassignment.

Test fix

• provider-loader-cuda.test.js was asserting loaded === true but always got false. Root cause: the runner script patched fs.existsSync via import fs from 'fs', but provider-loader.js held a named ESM binding (import { existsSync } from 'fs') which is a frozen snapshot, not a live reference to module.exports. Fixed by:
  1. Changing provider-loader.js to import fs from 'fs' + fs.existsSync(...) (reads module.exports at call time).
  2. Using createRequire in the runner script to patch the CJS module.exports directly, which is the same object fs.existsSync reads through.

Provider loader

• ldconfig -p was called once per missing library (up to 6 times); output is now cached in a module-level variable.
• activateCuda and activateDml were declared async but contain no await; removed the unnecessary keyword.

CI

• Workflow used pnpm but the repo commits package-lock.json (npm). Switched to npm ci to match the lockfile.
• Node matrix expanded from [18.x] to [18.x, 20.x, 22.x].
• Artifact name now includes ${{ matrix.node-version }} to avoid upload conflicts across matrix legs.

Package / DX

• Added "exports" field to package.json for proper ESM subpath resolution.
• Removed bench/ from "files" — the benchmarking scripts were being shipped to npm consumers.
• Added semi, eqeqeq, no-var, prefer-const to eslint.config.cjs.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• huggingface.co
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/embedeer/embedeer/bench/grid-search.js --device cpu --sample-size 1 --out /tmp/embedeer-grid-CdZEof/grid-out.json (dns block)
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/embedeer/embedeer/bench/grid-search.js --device cpu --sample-size 1 --out /tmp/embedeer-grid-gxqcZZ/grid-out.json (dns block)
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/embedeer/embedeer/bench/grid-search.js --device cpu --sample-size 1 --out /tmp/embedeer-grid-u8kF2J/grid-out.json (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[jsilvanus]

Was implemented in #6