fix: use default child_process import so test stubs can intercept execFileSync#7
Merged
Merged
Conversation
…cFileSync
Named ESM imports (`import { execFileSync } from 'child_process'`) are snapshots
and cannot be patched at runtime via the module.exports object. The grid-search
test stub (`child_process.execFileSync = () => {}`) only works through the default
import's live binding. Switching to `import childProcess from 'child_process'`
and calling `childProcess.execFileSync(...)` makes the stub effective and prevents
the real grid-search subprocess from running in CI where network is blocked.
https://claude.ai/code/session_01WKLNCnwF2psdSJc8291RWr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Named ESM imports (
import { execFileSync } from 'child_process') are snapshotsand cannot be patched at runtime via the module.exports object. The grid-search
test stub (
child_process.execFileSync = () => {}) only works through the defaultimport's live binding. Switching to
import childProcess from 'child_process'and calling
childProcess.execFileSync(...)makes the stub effective and preventsthe real grid-search subprocess from running in CI where network is blocked.
https://claude.ai/code/session_01WKLNCnwF2psdSJc8291RWr