Commit eaa09ea
committed
fix(ios): address Cursor Bugbot review findings on PR invertase#8933
- analytics: include FirebaseAnalytics/IdentitySupport when
$RNFirebaseDisableSPM forces CocoaPods on RN >= 0.75. The previous
`unless defined?(spm_dependency)` guard skipped the IdentitySupport
block even when the user explicitly opted out of SPM.
- installations: remove redundant `#import "FirebaseInstallations/
FIRInstallations.h"` from RNFBInstallationsModule.m. The symbols
are already provided by the conditional import block above (via
<Firebase/Firebase.h> on CocoaPods or @import FirebaseInstallations
on SPM). The quoted header path was a CocoaPods-only artifact that
could fail to resolve in SPM mode.1 parent 2725045 commit eaa09ea
2 files changed
Lines changed: 1 addition & 3 deletions
File tree
- packages
- analytics
- installations/ios/RNFBInstallations
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| |||
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | 29 | | |
32 | 30 | | |
33 | 31 | | |
| |||
0 commit comments