Update to JsonApiDotNetCore v5.11.0 (#186)

Author: bkoelman

.config/dotnet-tools.json

@@ -3,7 +3,7 @@
   "isRoot": true,
   "tools": {
     "jetbrains.resharper.globaltools": {
-      "version": "2025.3.4",
+      "version": "2026.1.2",
       "commands": [
         "jb"
       ],
@@ -17,7 +17,7 @@
       "rollForward": false
     },
     "dotnet-reportgenerator-globaltool": {
-      "version": "5.5.4",
+      "version": "5.5.10",
       "commands": [
         "reportgenerator"
       ],

.github/ISSUE_TEMPLATE/config.yml

@@ -6,8 +6,8 @@ contact_links:
 - name: Sponsor JsonApiDotNetCore
   url: https://github.com/sponsors/json-api-dotnet
   about: Help the continued development.
-- name: Ask on Gitter
-  url: https://gitter.im/json-api-dotnet-core/Lobby
+- name: Ask on GitHub Discussions
+  url: https://github.com/json-api-dotnet/JsonApiDotNetCore/discussions
   about: Get in touch with the whole community.
 - name: Ask on Stack Overflow
   url: https://stackoverflow.com/questions/tagged/json-api

.github/workflows/build.yml

@@ -14,7 +14,7 @@ on:
   push:
     branches: [ 'master', 'release/**' ]
   release:
-    types: [published]
+    types: [ published ]
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -23,15 +23,15 @@ concurrency:
 env:
   DOTNET_NOLOGO: true
   DOTNET_CLI_TELEMETRY_OPTOUT: true
-  SOLUTION_FILE: JsonApiDotNetCore.MongoDb.sln
+  SOLUTION_FILE: JsonApiDotNetCore.MongoDb.slnx
 
 jobs:
   build-and-test:
     timeout-minutes: 60
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, windows-latest, macos-latest]
+        os: [ ubuntu-latest, windows-latest, macos-latest ]
     runs-on: ${{ matrix.os }}
     permissions:
       contents: read
@@ -114,7 +114,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, windows-latest, macos-latest]
+        os: [ ubuntu-latest, windows-latest, macos-latest ]
     runs-on: ${{ matrix.os }}
     permissions:
       contents: read
@@ -140,7 +140,7 @@ jobs:
         $inspectCodeOutputPath = Join-Path $env:RUNNER_TEMP 'jetbrains-inspectcode-results.xml'
         Write-Output "INSPECT_CODE_OUTPUT_PATH=$inspectCodeOutputPath" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
         dotnet jb inspectcode --version
-        dotnet jb inspectcode $env:SOLUTION_FILE --build --dotnetcoresdk=$(dotnet --version) --output="$inspectCodeOutputPath" --format="xml" --profile=WarningSeverities.DotSettings --properties:Configuration=Release --properties:ContinuousIntegrationBuild=false --properties:RunAnalyzers=false --severity=WARNING --verbosity=WARN -dsl=GlobalAll -dsl=GlobalPerProduct -dsl=SolutionPersonal -dsl=ProjectPersonal
+        dotnet jb inspectcode $env:SOLUTION_FILE --build --no-updates --dotnetcoresdk=$(dotnet --version) --output="$inspectCodeOutputPath" --format="xml" --settings=WarningSeverities.DotSettings --properties:"Configuration=Release;RunAnalyzers=false;NuGetAudit=false;ContinuousIntegrationBuild=false" --severity=WARNING --verbosity=WARN --disable-settings-layers="GlobalAll;GlobalPerProduct;SolutionPersonal;ProjectPersonal"
     - name: Verify outcome
       shell: pwsh
       run: |
@@ -156,7 +156,7 @@ jobs:
                             $issueType = $xml.report.IssueTypes.SelectSingleNode("IssueType[@Id='$($_.TypeId)']")
                             $severity = $_.Severity ?? $issueType.Severity
 
-                            Write-Output "[$severity] $($_.File):$($_.Line) $($_.TypeId): $($_.Message)"
+                            Write-Output "[$severity] ($($_.TargetFramework)) $($_.File):$($_.Line) $($_.TypeId): $($_.Message)"
                         })
                     })
                 }
@@ -168,11 +168,11 @@ jobs:
         }
 
   cleanup-code:
-    timeout-minutes: 60
+    timeout-minutes: 90
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, windows-latest, macos-latest]
+        os: [ ubuntu-latest, windows-latest, macos-latest ]
     runs-on: ${{ matrix.os }}
     permissions:
       contents: read
@@ -194,7 +194,9 @@ jobs:
     - name: Restore tools
       run: dotnet tool restore
     - name: Restore packages
-      run: dotnet restore
+      run: dotnet restore /p:NuGetAudit=false
+    - name: Build
+      run: dotnet build --no-restore --configuration Release /p:RunAnalyzers=false
     - name: CleanupCode (on PR diff)
       if: ${{ github.event_name == 'pull_request' }}
       shell: pwsh
@@ -206,14 +208,14 @@ jobs:
 
         Write-Output "Running code cleanup on commit range $baseCommitHash..$headCommitHash in pull request."
         dotnet jb cleanupcode --version
-        dotnet regitlint -s $env:SOLUTION_FILE --print-command --skip-tool-check --max-runs=5 --jb --dotnetcoresdk=$(dotnet --version) --jb-profile="JADNC Full Cleanup" --jb --properties:Configuration=Release --jb --properties:RunAnalyzers=false --jb --verbosity=WARN -f commits -a $headCommitHash -b $baseCommitHash --fail-on-diff --print-diff
+        dotnet regitlint -s $env:SOLUTION_FILE --print-command --skip-tool-check --max-runs=5 --jb --dotnetcoresdk=$(dotnet --version) --jb-profile="JADNC Full Cleanup" --jb --no-updates --jb --properties:"Configuration=Release;RunAnalyzers=false;NuGetAudit=false" --jb --verbosity=WARN -f commits -a $headCommitHash -b $baseCommitHash --fail-on-diff --print-diff
     - name: CleanupCode (on branch)
       if: ${{ github.event_name == 'push' || github.event_name == 'release' || github.event_name == 'workflow_dispatch' }}
       shell: pwsh
       run: |
         Write-Output 'Running code cleanup on all files.'
         dotnet jb cleanupcode --version
-        dotnet regitlint -s $env:SOLUTION_FILE --print-command --skip-tool-check --jb --dotnetcoresdk=$(dotnet --version) --jb-profile="JADNC Full Cleanup" --jb --properties:Configuration=Release --jb --properties:RunAnalyzers=false --jb --verbosity=WARN --fail-on-diff --print-diff
+        dotnet regitlint -s $env:SOLUTION_FILE --print-command --skip-tool-check --jb --dotnetcoresdk=$(dotnet --version) --jb-profile="JADNC Full Cleanup" --jb --no-updates --jb --properties:"Configuration=Release;RunAnalyzers=false;NuGetAudit=false" --jb --verbosity=WARN --fail-on-diff --print-diff
 
   publish:
     timeout-minutes: 60

.github/workflows/codeql.yml

@@ -8,6 +8,10 @@ on:
   schedule:
     - cron: '0 0 * * 5'
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   analyze:
     name: Analyze

.github/workflows/deps-review.yml

@@ -1,5 +1,9 @@
 name: 'Dependency Review'
-on: [pull_request]
+on: [ pull_request ]
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 
 permissions:
   contents: read
@@ -13,4 +17,4 @@ jobs:
       with:
         persist-credentials: false
     - name: 'Dependency Review'
-      uses: actions/dependency-review-action@v4
+      uses: actions/dependency-review-action@v5

.idea/.idea.JsonApiDotNetCore.MongoDb/.idea/codeStyles/Project.xml

@@ -1,29 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <RuleSet Name="Coding Guidelines" Description=" " ToolsVersion="17.0">
-  <Rules AnalyzerId="CSharpGuidelinesAnalyzer" RuleNamespace="CSharpGuidelinesAnalyzer">
-    <Rule Id="AV1008" Action="Warning" />
-    <Rule Id="AV1135" Action="None" />
-    <Rule Id="AV1500" Action="None" />
-    <Rule Id="AV1505" Action="Warning" />
-    <Rule Id="AV1506" Action="Warning" />
-    <Rule Id="AV1507" Action="Warning" />
-    <Rule Id="AV1536" Action="None" />
-    <Rule Id="AV1537" Action="None" />
-    <Rule Id="AV1551" Action="None" />
-    <Rule Id="AV1564" Action="None" />
-    <Rule Id="AV1568" Action="Warning" />
-    <Rule Id="AV1580" Action="None" />
-    <Rule Id="AV1704" Action="None" />
-    <Rule Id="AV1710" Action="None" />
-    <Rule Id="AV1711" Action="None" />
-    <Rule Id="AV1738" Action="Warning" />
-    <Rule Id="AV1739" Action="Warning" />
-    <Rule Id="AV1745" Action="Warning" />
-    <Rule Id="AV2220" Action="Warning" />
-    <Rule Id="AV2230" Action="Info" />
-    <Rule Id="AV2305" Action="None" />
-    <Rule Id="AV2318" Action="Warning" />
-  </Rules>
   <Rules AnalyzerId="Microsoft.CodeAnalysis.NetAnalyzers" RuleNamespace="Microsoft.CodeAnalysis.NetAnalyzers">
     <Rule Id="CA1027" Action="Warning" />
     <Rule Id="CA1033" Action="Warning" />

CSharpGuidelinesAnalyzer.config

@@ -9,7 +9,7 @@
     <AnalysisMode>Recommended</AnalysisMode>
     <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)CodingGuidelines.ruleset</CodeAnalysisRuleSet>
     <RunSettingsFilePath>$(MSBuildThisFileDirectory)tests.runsettings</RunSettingsFilePath>
-    <VersionPrefix>5.10.1</VersionPrefix>
+    <VersionPrefix>5.11</VersionPrefix>
     <VersionSuffix>pre</VersionSuffix>
   </PropertyGroup>
 
@@ -49,8 +49,6 @@
 
   <ItemGroup>
     <PackageReference Include="JetBrains.Annotations" Version="2025.2.*" PrivateAssets="All" />
-    <PackageReference Include="CSharpGuidelinesAnalyzer" Version="3.8.*" PrivateAssets="All" />
-    <AdditionalFiles Include="$(MSBuildThisFileDirectory)CSharpGuidelinesAnalyzer.config" Visible="False" />
   </ItemGroup>
 
   <ItemGroup>

CodingGuidelines.ruleset

@@ -24,6 +24,7 @@
           <table style="width:100%">
             <tr>
               <th>File</th>
+              <th>Target Framework</th>
               <th>Line Number</th>
               <th>Type</th>
               <th>Message</th>
@@ -33,6 +34,9 @@
                 <td>
                   <xsl:value-of select="@File"/>
                 </td>
+                <td>
+                  <xsl:value-of select="@TargetFramework"/>
+                </td>
                 <td>
                   <xsl:value-of select="@Line"/>
                 </td>