Fix build errors

Author: bkoelman

src/Examples/DapperExample/TranslationToSql/Builders/SqlQueryBuilder.cs

@@ -452,7 +452,7 @@ private void AppendOnNewLine(string? value, StringBuilder builder)
                 builder.AppendLine();
             }
 
-            builder.Append(new string(' ', _indentDepth * 4));
+            builder.Append(' ', _indentDepth * 4);
             builder.Append(value);
         }
     }

src/JsonApiDotNetCore/Diagnostics/CascadingCodeTimer.cs

@@ -263,7 +263,7 @@ private void WriteResult(StringBuilder builder, int indent, TimeSpan timeElapsed
 
         private static void WriteIndent(StringBuilder builder, int indent)
         {
-            builder.Append(new string(' ', indent * 2));
+            builder.Append(' ', indent * 2);
         }
 
         private void WritePadding(StringBuilder builder, int indent, int paddingLength)

src/JsonApiDotNetCore/Queries/IndentingStringWriter.cs

@@ -12,7 +12,7 @@ public void WriteLine(string? line)
     {
         if (_indentDepth > 0)
         {
-            _builder.Append(new string(' ', _indentDepth * 2));
+            _builder.Append(' ', _indentDepth * 2);
         }
 
         _builder.AppendLine(line);

test/OpenApiTests/AttributeTypes/AttributeTypeTests.cs

@@ -8,11 +8,14 @@ namespace OpenApiTests.AttributeTypes;
 public sealed class AttributeTypeTests : IClassFixture<OpenApiTestContext<AttributeTypesStartup, AttributeTypesDbContext>>
 {
     public static readonly TheoryData<string> SchemaNames =
-    [
-        "attributesInCreateTypeContainerRequest",
-        "attributesInUpdateTypeContainerRequest",
-        "attributesInTypeContainerResponse"
-    ];
+#pragma warning disable CA1825 // Avoid zero-length array allocations
+        // Justification: Workaround for bug https://github.com/dotnet/roslyn/issues/82484.
+        [
+            "attributesInCreateTypeContainerRequest",
+            "attributesInUpdateTypeContainerRequest",
+            "attributesInTypeContainerResponse"
+        ];
+#pragma warning restore CA1825 // Avoid zero-length array allocations
 
     private readonly OpenApiTestContext<AttributeTypesStartup, AttributeTypesDbContext> _testContext;
 

test/OpenApiTests/ModelStateValidation/ModelStateValidationTests.cs

@@ -8,11 +8,14 @@ namespace OpenApiTests.ModelStateValidation;
 public sealed class ModelStateValidationTests : IClassFixture<OpenApiTestContext<OpenApiStartup<ModelStateValidationDbContext>, ModelStateValidationDbContext>>
 {
     public static readonly TheoryData<string> SchemaNames =
-    [
-        "attributesInCreateSocialMediaAccountRequest",
-        "attributesInUpdateSocialMediaAccountRequest",
-        "attributesInSocialMediaAccountResponse"
-    ];
+#pragma warning disable CA1825 // Avoid zero-length array allocations
+        // Justification: Workaround for bug https://github.com/dotnet/roslyn/issues/82484.
+        [
+            "attributesInCreateSocialMediaAccountRequest",
+            "attributesInUpdateSocialMediaAccountRequest",
+            "attributesInSocialMediaAccountResponse"
+        ];
+#pragma warning restore CA1825 // Avoid zero-length array allocations
 
     private readonly OpenApiTestContext<OpenApiStartup<ModelStateValidationDbContext>, ModelStateValidationDbContext> _testContext;
 

test/TestBuildingBlocks/CapturingLoggerProvider.cs

@@ -16,6 +16,8 @@ public sealed class CapturingLoggerProvider : ILoggerProvider
     private static readonly Func<string, LogLevel, bool> DefaultFilter = (_, _) => true;
     private readonly Func<string, LogLevel, bool> _filter;
 
+    // ReSharper disable once ChangeFieldTypeToSystemThreadingLock
+    // Justification: Workaround for bug https://youtrack.jetbrains.com/issue/RSRP-503024/Regression-Use-System.Threading.Lock-on-.NET-11.
     private readonly LockPrimitive _lockObject = new();
     private readonly List<LogMessage> _messages = [];