test(format/date-time): add timezone offset boundary and leap second cases#953
Open
AcEKaycgR wants to merge 1 commit into
Open
test(format/date-time): add timezone offset boundary and leap second cases#953AcEKaycgR wants to merge 1 commit into
AcEKaycgR wants to merge 1 commit into
Conversation
a20f823 to
52a37aa
Compare
Contributor
|
@AcEKaycgR I checked the verdicts against section 5.6 (
These eight inputs are also all in your #891, we can close that one once we're ready with this. |
52a37aa to
c665b77
Compare
Contributor
Author
|
Hi @vtushar06, Thanks for pointing that out. I have removed the duplicate 2016 leap second case I also noticed you have already opened separate PRs (#960 and #961) for the other offset minutes and leap second hour boundaries you found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies to: draft-v1, draft-07, draft/2019-09, draft/2020-12
Adds 8 new cases asserting strict timezone offset formatting, floor/ceiling bounds, and IERS leap second compliance in the
date-timeformat.Added:
Ecosystem Impact (Triangulation):
Under Bowtie verification against 8 active implementations, these cases successfully caught live compliance issues:
php-opis-json-schemaincorrectly validates the invalid leap second with non-UTC offset ("1998-12-31T23:59:60+01:00") asvalid(expectedinvalid), failing to assert that leap seconds can only align with UTC midnight.go-gojsonschemaincorrectly validates the valid leap second"2016-12-31T23:59:60Z"asinvaliddue to Go standard runtime limitations on leap second support.@jviotti @jdesrosiers @karenetheridge Ready for review.