test(format/uri): add strict percent-encoding syntax and non-ASCII character cases#956
Open
AcEKaycgR wants to merge 1 commit into
Open
test(format/uri): add strict percent-encoding syntax and non-ASCII character cases#956AcEKaycgR wants to merge 1 commit into
AcEKaycgR wants to merge 1 commit into
Conversation
7906fb6 to
abe6809
Compare
abe6809 to
7f0dd9a
Compare
jviotti
approved these changes
Jun 29, 2026
jviotti
left a comment
Member
There was a problem hiding this comment.
Interesting. I would have said some tests are very similar to others around percentage encoding, but I think we should accept them as-is if you managed to prove existing implementations break with them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies to: draft-v1, draft-04, draft-06, draft-07, draft/2019-09, draft/2020-12
Adds 12 new cases validating strict percent-encoding syntax triplets, caret/hash delimiters, and non-ASCII character constraints in the
uriformat.Added:
%+ 1 digit in query (invalid)%G0in query (invalid)%in query (invalid)^in query (invalid)%+ 1 digit in fragment (invalid)%G0in fragment (invalid)%in fragment (invalid)#in fragment (invalid)^in fragment (invalid)Ecosystem Impact (Triangulation):
Under Bowtie verification against 8 active implementations, these cases successfully caught live compliance issues:
"%2"), invalid hex ("%G0"), and lone percents ("%") in queries and fragments.go-gojsonschemaincorrectly accepts raw non-ASCIIéand carets in queries and fragments.go-gojsonschemaincorrectly rejects valid percent-encoding in host reg-names ("http://ex%61mple.com").@jviotti @jdesrosiers @karenetheridge Ready for review.