test(format/uri): assert IPv6 and IPvFuture host formatting constraints#957
Open
AcEKaycgR wants to merge 1 commit into
Open
test(format/uri): assert IPv6 and IPvFuture host formatting constraints#957AcEKaycgR wants to merge 1 commit into
AcEKaycgR wants to merge 1 commit into
Conversation
83f1ffe to
37c7ad7
Compare
37c7ad7 to
6918888
Compare
jviotti
approved these changes
Jun 29, 2026
jviotti
left a comment
Member
There was a problem hiding this comment.
Very nice. Looks all correct as far as I can tell and I appreciate the evidence on the ones that break!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies to: draft-v1, draft-04, draft-06, draft-07, draft/2019-09, draft/2020-12
Adds 20 new cases asserting strict syntax constraints on IPv6 and IPvFuture host formats, including square bracket requirements, and Cyrillic/non-ASCII host rejections.
Added:
[]host (invalid)Ecosystem Impact (Triangulation):
Under Bowtie verification against 8 active implementations, these cases successfully caught live compliance issues:
go-gojsonschemaincorrectly accepts unbracketed IPv6, empty brackets, brackets in path/query/fragment, and malformed IPv6/IPvFuture hosts.go-gojsonschemaincorrectly accepts Cyrillic and non-ASCII Latin characters in host names.php-opis-json-schemaincorrectly rejects valid IPv6 with embedded IPv4 ("http://[::ffff:192.168.1.1]"), valid IPvFuture hosts, and uppercaseVversions.php-opis-json-schemaincorrectly accepts brackets in query/fragment.@jviotti @jdesrosiers @karenetheridge Ready for review.