test(format/uri): add port syntax limits and empty host/userinfo boundary cases#958
Open
AcEKaycgR wants to merge 1 commit into
Open
test(format/uri): add port syntax limits and empty host/userinfo boundary cases#958AcEKaycgR wants to merge 1 commit into
AcEKaycgR wants to merge 1 commit into
Conversation
AcEKaycgR
force-pushed
the
uri-port-userinfo-boundaries
branch
2 times, most recently
from
91aca09 to
dd11e1d
Compare
jviotti
reviewed
Jun 29, 2026
| "valid": false | ||
| }, | ||
| { | ||
| "description": "above-ceiling DIGIT in port: colon is %x3A, one above 9 (%x39)", |
Member
There was a problem hiding this comment.
Not sure I follow this description. What 9 are you referring to?
Member
There was a problem hiding this comment.
Ahhh OK you mean at the ASCII level. I think it can be clarified a bit more probably, as its not a DIGIT anymore?
jviotti
reviewed
Jun 29, 2026
| "valid": false | ||
| }, | ||
| { | ||
| "description": "port digit boundary: one above range (colon)", |
Member
There was a problem hiding this comment.
I think this description can be improved too. It took me a while to understand it, at least me
AcEKaycgR
force-pushed
the
uri-port-userinfo-boundaries
branch
from
dd11e1d to
9d0fd09
Compare
Contributor
Author
|
Hi @jviotti, I've renamed both test descriptions to make them much simpler and clearer:
Thanks for the feedback. |
jviotti
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies to: draft-v1, draft-04, draft-06, draft-07, draft/2019-09, draft/2020-12
Adds 11 new cases validating port boundaries, empty host/userinfo scanning limits, and host reg-name character compatibility.
Added:
:8:0and::(invalid)@(valid)Ecosystem Impact (Triangulation):
Under Bowtie verification against 8 active implementations, these cases successfully caught live compliance issues:
go-gojsonschemaincorrectly accepts invalid colons in port.php-opis-json-schemaincorrectly rejects empty ports, ports with no upper bound, empty host with port, empty host with userinfo, sub-delimiters, trailing dots, tildes, and underscores in host reg-names.@jviotti @jdesrosiers @karenetheridge Ready for review.