fix: ensure Media Partner image renders consistently across themes#1928
Closed
nandu-99 wants to merge 1 commit into
Closed
fix: ensure Media Partner image renders consistently across themes#1928nandu-99 wants to merge 1 commit into
nandu-99 wants to merge 1 commit into
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1928 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 633 633
Branches 196 196
=========================================
Hits 633 633 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hi @Honyii , do we have any logo for Dev events for light theme ? |
Contributor
|
No I didn't have the light mode design for dev events @Utkarsh-123github , @nandu-99 thanks for bringing this up and your enthusiasm is commendable! |
Author
|
@Honyii Thank you |
Member
|
Thanks Honyii for the clarification. |
github-project-automation
Bot
moved this from Ready to review
to Done
in PR - Triage Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix — ensures the "Dev Events" Media Partner image loads properly in both light and dark modes, including after page reloads.
Issue Number:
Closes #1925
Screenshots/videos:
If relevant, did you update the documentation?
Not needed — no documentation changes required.
Summary
This PR fixes an issue where the “Dev Events” image under the Media Partner section failed to render in light mode after a page reload, despite displaying correctly in dark mode.
Does this PR introduce a breaking change?
No — this fix is fully backward-compatible.
Checklist
Please ensure the following tasks are completed before submitting this pull request.